Re: [vim/vim] patch 9.1.0050: Win32 Keyboard handling is sub-optimal (68d9472)

risa2000

unread,

Jan 27, 2024, 10:13:06 AM1/27/24

to vim/vim, Subscribed

Just a comment on the wording in the help file and for the potential future pioneers who might want to go the "experimental" way:

TranslateMessage() is defacto the implementation of the localized keyboard layouts in Windows. Wording it as if it just handles some "corner cases" might be misleading. Doing the localized layouts without it correctly will be hard for two reasons: there are so many layouts, and they are not pure mechanical translations, what a user used to English layout might think. I went already in length about all implications in #12595 so will not repeat it.
TLDR: I do not think it is worth the effort.

Second point is about the experimental vs classic distinction. My understanding and the main reason why I suggested this approach in the end (but I believe @ant0sha might have already had it implemented) was to keep the experimental code in out of the respect for people who either wanted or would want to continue working on it (despite the disclaimer I wrote above) and bring it on par with the classic. So the distinction was in my opinion targeted at developers.

For what concerns users, I guess apart from the corner(sic!) cases the "experimental" approach tried to solve, the regular users, unless they really need some of the experimental functionality, should be better to stick to the classic - because this one should work on any layout and on any version (in a sense of the key mappings being shared).

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

h_east

unread,

Feb 18, 2024, 8:11:01 AM2/18/24

to vim/vim, Subscribed

Typo.
s/trans\zs\zeation/l/

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

h_east

unread,

Feb 18, 2024, 9:44:41 AM2/18/24

to vim/vim, Subscribed

I made a PR with some other corrections.
#14054

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

wildekat

unread,

Mar 21, 2024, 3:27:15 PM3/21/24

to vim/vim, Subscribed

<C-[> still seems to be broken for certain Cyrillic keyboard layouts.
I'm using Vim-9.1.0181 on Windows 10 with the standard/most common Russian keyboard layout,
where Ctrl+Cyrillic letter х is supposed to have the same effect as <C-[> (<Esc>).
However, whether I try it in Insert, Normal, or Visual mode, it doesn't seem to produce any effect whatsoever.
I have also tried mapping it explicitly and setting set_keycode_trans_strategy, both to no avail.

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Mar 21, 2024, 10:23:05 PM3/21/24

to vim/vim, Subscribed

@wildekat Could you create a new issue about it?
Does it work before v8.2.4807?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

risa2000

unread,

Mar 22, 2024, 5:11:42 AM3/22/24

to vim/vim, Subscribed

@wildekat Just out of curiosity - do you see the same behavior in both gVim and console vim (with default set_keycode_trans_strategy)?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

wildekat

unread,

Mar 22, 2024, 8:55:49 AM3/22/24

to vim/vim, Subscribed

@k-takata
Yes, absolutely, it did work prior to 8.2.4807.
OK, I'll do my best to submit a proper bug report.

@risa2000
The issue seems to only affect gVim. In console Vim, <C-х> never fails to produce the desired <C-[> effect (tested in Insert/Command/OP/Visual modes).