[vim/vim] Did getbufline() recently changed behaviour? (Issue #19301)

[ubaldot]

ubaldot created an issue (vim/vim#19301)

I am recently having troubles with some CI tests of a plugin that I am developing, and it only happens with recent Vim nightly builds (for example, the tests pass with 9.1.2001).
The issue seems to be connected to getbufline().

For instance, given a buffer with the following content:

a = 1
b = 2

the command echo getbufline('%', 1, '$') is supposed to return ['a = 1', 'b = 2'] but in newer versions of Vim it seems to return ['a = 1', 'b = 2', ''].

Can anyone confirm?

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/19301@github.com>

[zeertzjq]

zeertzjq left a comment (vim/vim#19301)

Still returns ['a = 1', 'b = 2'] for me in 9.1.2125.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/19301/3830609549@github.com>

[zeertzjq]

zeertzjq left a comment (vim/vim#19301)

I think the change may come from #19288.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/19301/3830614967@github.com>

[ubaldot]

ubaldot left a comment (vim/vim#19301)

How many days is "a few days ago"?

On Jan 29th everything seemed to work.
I forgot to mention that the issue is only on Ubuntu and MacOs.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/19301/3830864022@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#19301)

cannot reproduce with latest master

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/19301/3831122832@github.com>

[ubaldot]

ubaldot left a comment (vim/vim#19301)

I found the issue. The problem comes after this bugfix.

In my code I have a blob2str(base64_decode(payload)) and if payload is MTEwCg== the buggy version return 110, whereas the correct version returns 110\n. Then, if you set or get such a string from a buffer, you get different results, depending on what version of blob2str you are using.

This means that I will have to update my tests and the minimum Vim requirements to patch 2120 in my CI.
I don't see the utilization of has_patch() a nice solution.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/19301/3834941927@github.com>

[ubaldot]

Closed #19301 as completed.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issue/19301/issue_event/22464670513@github.com>