[vim/vim] Fix "-- VISUAL --" not shown when terminal responses are pending (PR #19801)
h_east
When starting Vim with a script that enters Visual mode (e.g. "vim -S script.vim"), the "-- VISUAL --" mode message sometimes doesn't appear. This happens because skip_showmode() calls char_avail(), which reads raw terminal input and picks up terminal response escape sequences (e.g. t_RV response). Combined with !KeyTyped (which is TRUE after script execution), this causes skip_showmode() to return TRUE, preventing the mode from being displayed.
Fix this by checking only the stuff buffer and typeahead buffer for pending characters, instead of char_avail() which also reads raw terminal input. This way, terminal response sequences no longer interfere with mode display.
closes: #16620
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19801
Commit Summary
- ba228e7 Fix "-- VISUAL --" not shown when terminal responses are pending
File Changes
(1 file)
- M src/screen.c (8)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
In src/screen.c:
> if (global_busy || msg_silent != 0 || !redrawing() - || (char_avail() && !KeyTyped)) + || ((!stuff_empty() || typebuf.tb_len > 0) && !KeyTyped))
Hm, should it be:
⬇️ Suggested change- || ((!stuff_empty() || typebuf.tb_len > 0) && !KeyTyped)) + || ((!stuff_empty() || typebuf.tb_len > 0 || using_script()) && !KeyTyped))
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east commented on this pull request.
In src/screen.c:
> if (global_busy || msg_silent != 0 || !redrawing() - || (char_avail() && !KeyTyped)) + || ((!stuff_empty() || typebuf.tb_len > 0) && !KeyTyped))
Right. Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- f0a6179 Update src/screen.c
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- c9575dc Tweaking line breaks and function comments
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19801)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.