[vim/vim] GTK4: Support Vim specific formats for clipboard (PR #20445)
Foxe Chen
Currently the GTK4 GUI does not support Vim's internal specific formats that preserve motion type and encoding. It also doesn't support the 'html' option in 'clipboard'. This PR adds support for both.
A problem I came across is that GTK4 only supports conforming mime types in the clipboard. So the current naming of the formats ("_VIMENC_TEXT" & "_VIM_TEXT") do not work. To get around this I created a new set of formats called "application/x-vim-text" and "application/x-vim-enc-text", which do the same thing. The X11/GTK3/Wayland clipboard functionality also expose and use these formats as well in addition to the old format names. See // https://gitlab.gnome.org/GNOME/gtk/-/work_items/4087 and https://discourse.gnome.org/t/gtk4-clipboard-does-not-provide-contents-using-custom-mime-type-without-character/6858 for more info.
Another benefit is now clipboard data is only retrieved from the registers when a client requests it (on Wayland and X11). This makes the autoselect feature more efficient on the GTK4 GUI, since before it had to allocate a new string every time the visual selection changed.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20445
Commit Summary
- 5769701 support vim formats for gtk4 gui
File Changes
(10 files)
- M src/Makefile (12)
- M src/clipboard.c (163)
- M src/gui.h (4)
- M src/gui_gtk4.c (175)
- A src/gui_gtk4_cb.c (197)
- A src/gui_gtk4_cb.h (23)
- M src/gui_gtk_x11.c (32)
- M src/proto/clipboard.pro (2)
- M src/testdir/test_wayland.vim (3)
- M src/vim.h (5)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.