This is a continuation of #14752, and while syntax highlghiting improved a lot there is still a minor issue with the following config:
floating_modifier $mod normal
The "normal" string shows up in red.
Here's a screenshot of what it currently looks like:
20240522_15h22m56s_grim.png (view on web)
Syntax highlighting is properly applied to all commands.
9.1.429
Operating system: Arch Linux
Terminal: foot
Value of $TERM: foot
Shell: /usr/bin/bash
No response
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Should have been labelled as bug, and not enhancement. Anyway, @JosefLitos @jamespeapen (ping).
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
I can replicate this. It looks like contained
was introduced in 679f5ab to floating_modifier
in swayconfig.vim
which seems to conflict with the i3 floating_modifier
.
-syn match i3ConfigKeyword /^floating_modifier [$a-zA-Z0-9+]\+ \(normal\|inverse\)$/ contains=i3ConfigVariable,i3ConfigBindModkey,swayConfigFloatingModifierOpts +syn match i3ConfigKeyword /floating_modifier [$a-zA-Z0-9+]\+ \(normal\|inverse\)$/ contained contains=i3ConfigVariable,i3ConfigBindModkey,swayConfigFloatingModifierOpts
Removing this fixes this problem. However, on checking the docs, it looks like floating_modifier none
is a valid option that the syntax does not currently cover so I'll send a fix with both.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
@jamespeapen Thanks a lot again for your amazing work!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Closed #14826 as completed via 22ac941.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.