Fwd: syntax/vim.vim - support python << trim

12 views
Skip to first unread message

Ben Jackson

unread,
Nov 25, 2021, 4:54:46 AM11/25/21
to vim...@googlegroups.com, Bram Moolenaar
Hi Bram,
I proposed this patch a while back to Charles, but I don’t think I got a response.
It adds support for "py3 << trim EOF” in vim.vim syntax file.
I can make a GitHub PR if you prefer.
Ta
Ben

Begin forwarded message:

From: Ben Jackson <puremo...@gmail.com>
Subject: Re: syntax/vim.vim - support python << trim
Date: 3 April 2021 at 15:22:05 BST
To: Charles Campbell <camp...@drchip.org>

Attached correct patch. Sorry for the spam...

0001-Runtime-vim-python-syntax-supports-trim.patch

Bram Moolenaar

unread,
Nov 25, 2021, 5:51:35 AM11/25/21
to vim...@googlegroups.com, Ben Jackson

Ben Jackson wrote:

> I proposed this patch a while back to Charles, but I don’t think I got a
> response.
> It adds support for "py3 << trim EOF” in vim.vim syntax file.
> I can make a GitHub PR if you prefer.

You could make a PR and ping @cecamp
Charles is around but does not spend much time on Vim.

--
Violators can be fined, arrested or jailed for making ugly faces at a dog.
[real standing law in Oklahoma, United States of America]

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Ben Jackson

unread,
Nov 25, 2021, 5:52:25 AM11/25/21
to Bram Moolenaar, vim...@googlegroups.com
Thanks, Bram, will do.

Charles Campbell

unread,
Nov 25, 2021, 10:33:43 AM11/25/21
to vim...@googlegroups.com, Ben Jackson, Bram Moolenaar
Ben Jackson wrote:
> Thanks, Bram, will do.
>
I just looked over your patch. Why is it necessary? syntax/vim.vim,
without it, already handles

py3 <<trim
...
trim

where the "..." is already a python region; also, your insertion
requires trim to precede other words used to set off a python region
(ie. py3 << trimSomethingElse).
Please give an example, too. Is it because you want   py3 << trim
SomethingElse  supported (note the intervening space between trim and
SomethingElse)? Is the old  py3 <<SomethingElse  no longer supported,
and are you claiming that no one should use that form? I can make "py3
<< trim SomethingElse" supported without taking down  py3 <<
SomethingElse  .  Is what follows "trim", if anything, always just a
word or can it be a quoted expression, and does the python region
terminator also have just trim or "trim SomethingElse"?

Some information please!
Chip Campbell

Reply all
Reply to author
Forward
0 new messages