Build error on v8.1.1210 : expected ')' before 'compl' token

25 views
Skip to first unread message

niva...@gmail.com

unread,
Apr 28, 2019, 11:02:09 AM4/28/19
to vim_dev
Hi All,

Since v8.1.1210, I encounter this error :

-o gobji686/if_ole.o if_ole.cpp
In file included from proto.h:230:0,
from vim.h:2084,
from if_ole.cpp:22:
proto/usercmd.pro:2:74: error: expected ')' before 'compl' token
char_u *find_ucmd(exarg_T *eap, char_u *p, int *full, expand_T *xp, int *compl);
^~~~~
proto/usercmd.pro:2:74: error: expected initializer before 'compl' token
make: *** [Make_cyg_ming.mak:1061: gobji686/if_ole.o] Error 1

Building under Windows 10 from MSYS2 32bits with this command:
make -f Make_ming.mak OLE=yes DEBUG=no GUI=yes XPM=no DIRECTx=yes DYNAMIC_LUA=yes LUA=./lua-5.4.0/src LUA_VER=54 PYTHON3=/c/ThirdPart/Python37 DYNAMIC_PYTHON3=yes PYTHON3_VER=37 DYNAMIC_RUBY=no RUBY_VER=26 RUBY_API_VER_LONG=2.6.0 RUBY=/c/ThirdPart/Ruby26 TERMINAL=yes EVENT_LOOP=yes

Thank you in advance for help
NiVa

niva...@gmail.com

unread,
Apr 28, 2019, 2:22:53 PM4/28/19
to vim_dev
Sans titre.png

ktakat...@gmail.com

unread,
Apr 29, 2019, 2:20:30 PM4/29/19
to vim_dev
Hi,

It seems that "compl" is a keyword in C++, so it causes compilation error
when compiling if_ole.cpp as C++. ("compl" is the same as "~".) We should
avoid using "compl" as an argument here.

Attached patch should fix it.

Other workarounds:
* Stop using OLE.
* Use MSVC. MSVC doesn't complain this.

Regards,
Ken Takata

fix-if_ole-compl-error.patch

Ni Va

unread,
Apr 29, 2019, 2:48:33 PM4/29/19
to vim...@googlegroups.com
Hi and thanks a lot Ken.

I thought that msys2 and make ming, was less heavy than msvc.

I prefer using compiler more strict.

It seems that no much People is using msys2 and ming to build vim regarding up to 20 patchs to get some reply. 

Thank you Ken
NiVa

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to a topic in the Google Groups "vim_dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/vim_dev/DFMQwiJuUmU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to vim_dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

niva...@gmail.com

unread,
Apr 29, 2019, 2:49:27 PM4/29/19
to vim_dev

Bram Moolenaar

unread,
Apr 29, 2019, 3:31:08 PM4/29/19
to vim...@googlegroups.com, ktakat...@gmail.com

Ken Takata wrote:

> 2019/4/29 Mon 0:02:09 UTC+9 niva...@gmail.com wrote:
> > Hi All,
> >
> > Since v8.1.1210, I encounter this error :
> >
> > -o gobji686/if_ole.o if_ole.cpp
> > In file included from proto.h:230:0,
> > from vim.h:2084,
> > from if_ole.cpp:22:
> > proto/usercmd.pro:2:74: error: expected ')' before 'compl' token
> > char_u *find_ucmd(exarg_T *eap, char_u *p, int *full, expand_T *xp, int *compl);
> > ^~~~~
> > proto/usercmd.pro:2:74: error: expected initializer before 'compl' token
> > make: *** [Make_cyg_ming.mak:1061: gobji686/if_ole.o] Error 1
> >
> > Building under Windows 10 from MSYS2 32bits with this command:
> > make -f Make_ming.mak OLE=yes DEBUG=no GUI=yes XPM=no DIRECTx=yes DYNAMIC_LUA=yes LUA=./lua-5.4.0/src LUA_VER=54 PYTHON3=/c/ThirdPart/Python37 DYNAMIC_PYTHON3=yes PYTHON3_VER=37 DYNAMIC_RUBY=no RUBY_VER=26 RUBY_API_VER_LONG=2.6.0 RUBY=/c/ThirdPart/Ruby26 TERMINAL=yes EVENT_LOOP=yes
>
> It seems that "compl" is a keyword in C++, so it causes compilation error
> when compiling if_ole.cpp as C++. ("compl" is the same as "~".) We should
> avoid using "compl" as an argument here.

Another reason why I don't like C++...

> Attached patch should fix it.
>
> Other workarounds:
> * Stop using OLE.
> * Use MSVC. MSVC doesn't complain this.

We already use "complp" in another place, so let's use that.

--
The early bird gets the worm. If you want something else for
breakfast, get up later.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

niva...@gmail.com

unread,
Apr 29, 2019, 3:35:23 PM4/29/19
to vim_dev
Totally agree, "the door open to all windows" !

Thank a lot Bram ;)
Reply all
Reply to author
Forward
0 new messages