Commit: patch 9.1.1990: tests: Test_term_gettty() fails when using conpty on Windows

0 views
Skip to first unread message

Christian Brabandt

unread,
Dec 17, 2025, 3:00:56 PM (11 hours ago) Dec 17
to vim...@googlegroups.com
patch 9.1.1990: tests: Test_term_gettty() fails when using conpty on Windows

Commit: https://github.com/vim/vim/commit/bbbc23ac2f6767630ebd7da9754ee0501a585c1a
Author: Muraoka Taro <koron....@gmail.com>
Date: Wed Dec 17 20:52:32 2025 +0100

patch 9.1.1990: tests: Test_term_gettty() fails when using conpty on Windows

Problem: tests: Test_term_gettty() fails when using conpty on Windows,
CI uses winpty, so this test passes.
Solution: Skip the test Test_term_gettty(). Since conpty communicates
via anonymous pipes, there is no name that can be obtained
with term_gettty() (Muraoka Taro)

closes: #18954

Signed-off-by: Muraoka Taro <koron....@gmail.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_vim9_builtin.vim b/src/testdir/test_vim9_builtin.vim
index e66a33b6e..a07ba8c09 100644
--- a/src/testdir/test_vim9_builtin.vim
+++ b/src/testdir/test_vim9_builtin.vim
@@ -4766,6 +4766,9 @@ def Test_term_gettty()
CheckFeature terminal
else
var buf = g:Run_shell_in_terminal({})
+ if has('win32') && buf->term_getjob()->job_info()['tty_type'] == 'conpty'
+ throw 'Skipped: When using conpty, term_gettty() always returns an empty string.'
+ endif
term_gettty(buf, true)->assert_notequal('')
g:StopShellInTerminal(buf)
endif
diff --git a/src/version.c b/src/version.c
index 1b406f892..a36890701 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1990,
/**/
1989,
/**/
Reply all
Reply to author
Forward
0 new messages