Closes: #18002
Since patch 9.1.1585: Wayland: gvim still needs GVIM_ENABLE_WAYLAND,
the message window has been slow at drawing especially :version and
:highlight.
Since wayland redraws entire screen between updates (contrary to X11),
there are most likely- many more gains in perf in other paths not
discovered.
The issue is easily reproduced on;
Fullscreen, fractionally scaled, HiDPI displays (4K)
https://github.com/vim/vim/pull/19062
(4 files)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
@dezza pushed 1 commit.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@chrisbra commented on this pull request.
In src/gui.c:
> @@ -9,6 +9,9 @@ */ #include "vim.h" +#if defined(FEAT_GUI_X11) && GTK_CHECK_VERSION(3,0,0)
I think this should be:
#if defined(FEAT_GUI_X11) && defined(GDK_WINDOWING_WAYLAND) && GTK_CHECK_VERSION(3,0,0)
according to https://docs.gtk.org/gdk4/wayland.html
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@dezza commented on this pull request.
In src/gui.c:
> @@ -9,6 +9,9 @@ */ #include "vim.h" +#if defined(FEAT_GUI_X11) && GTK_CHECK_VERSION(3,0,0)
You linked the gdk4 docs, I will look into it, thanks.
Made PR into a draft, see the tests failing and now it seems its back to slow for me since editing it.
Will continue trying- I was sure I had it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@dezza pushed 4 commits.
You are receiving this because you are subscribed to this thread.![]()
@dezza pushed 4 commits.
You are receiving this because you are subscribed to this thread.![]()
@dezza pushed 4 commits.
You are receiving this because you are subscribed to this thread.![]()
@dezza pushed 4 commits.
You are receiving this because you are subscribed to this thread.![]()
@chrisbra hey chris, congrats on the new release, thanks for your continued valued effort and cheers to bram!
Did you see the new changes here?
Its a shame gvim is so slow, almost unusable imo. The "black" partial redraws mentioned and the slow scrolling as well as messagewin redraws.
My CPU was in for warranty just got a replacement, but will be installed shortly.
Reducing import guards in this PR definetily could happen, maybe just check gui.is_wayland and let that default to false when GDK_WINDOWING_WAYLAND false.
Regarding the vim_input_buf - how important is that for GUI? I understand X11 had reasons to trigger the g_main_context_iteration, but for wayland this seems to be different. I have not encountered missed key input at any point with that, but is there a case where it is critical? feedkeys?
Coverage tests ?
Try it out and see the improvement.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()