[vim/vim] Fix bug in zstd archive extraction. (PR #19930)

5 views
Skip to first unread message

Aaron B

unread,
3:03 AM (19 hours ago) 3:03 AM
to vim/vim, Subscribed

The tar.vim plugin allows vim to read and manipulate zstd archives,
but it had a bug that caused extraction attempts to fail. Specifically,
if the archive has a .tar.zst or .tzst extension, then the code was
generating invalid extraction commands that looked like this:

tar --zstdpxf foo.tar.zst foo

When they should be like this:

tar --zstd -pxf foo.tar.zst foo

This patch changes the flag manipulation logic so that --zstd isn't glued to pxf.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19930

Commit Summary

  • f1ad1f8 Fix bug in zstd archive extraction.

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930@github.com>

Aaron B

unread,
3:52 AM (18 hours ago) 3:52 AM
to vim/vim, Push

@7188ce06 pushed 1 commit.

  • 776a3be Better test failure messages.


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/320c54520432c0a1f93f91e8570dc9e56338c6a5/after/776a3be75108d6448353a64ad1da151e5871e7f6@github.com>

Aaron B

unread,
5:45 AM (16 hours ago) 5:45 AM
to vim/vim, Push

@7188ce06 pushed 1 commit.

  • e6a1b72 test to probe zstd support.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/776a3be75108d6448353a64ad1da151e5871e7f6/after/e6a1b721494be509bcfbc8a478dc77c657f81bc1@github.com>

Aaron B

unread,
5:48 AM (16 hours ago) 5:48 AM
to vim/vim, Push

@7188ce06 pushed 1 commit.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/e6a1b721494be509bcfbc8a478dc77c657f81bc1/after/209e397e1803b9a74c56e4617819c5e88df7f7f5@github.com>

Aaron B

unread,
6:22 AM (16 hours ago) 6:22 AM
to vim/vim, Push

@7188ce06 pushed 1 commit.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/209e397e1803b9a74c56e4617819c5e88df7f7f5/after/70beba9bbedc7585ecb28aebc4735102113a1093@github.com>

Aaron B

unread,
6:55 AM (15 hours ago) 6:55 AM
to vim/vim, Push

@7188ce06 pushed 1 commit.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/70beba9bbedc7585ecb28aebc4735102113a1093/after/17de6c784e2fac731980a76c81a2ebe6e38e168a@github.com>

Aaron B

unread,
7:05 AM (15 hours ago) 7:05 AM
to vim/vim, Push

@7188ce06 pushed 1 commit.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/17de6c784e2fac731980a76c81a2ebe6e38e168a/after/dce6408cedc848533930152bd688b12c9d98251d@github.com>

Aaron B

unread,
7:19 AM (15 hours ago) 7:19 AM
to vim/vim, Push

@7188ce06 pushed 1 commit.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/dce6408cedc848533930152bd688b12c9d98251d/after/f86f86dd3ed0e55107c7bce7bc6cc89bc8ec08e5@github.com>

Aaron B

unread,
3:21 PM (7 hours ago) 3:21 PM
to vim/vim, Push

@7188ce06 pushed 2 commits.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/f86f86dd3ed0e55107c7bce7bc6cc89bc8ec08e5/after/1a74d469575fb79d4c86abc7127d45debf4c4f89@github.com>

Aaron B

unread,
4:05 PM (6 hours ago) 4:05 PM
to vim/vim, Push

@7188ce06 pushed 2 commits.

  • 1127bff Fix bug in zstd archive extraction.
  • f621490 Make tar extraction work when paths have dots.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/1a74d469575fb79d4c86abc7127d45debf4c4f89/after/f6214904f359c13d9699345837253b46c6dce336@github.com>

Aaron B

unread,
4:12 PM (6 hours ago) 4:12 PM
to vim/vim, Push

@7188ce06 pushed 1 commit.

  • 5e42b16 Make tar extraction work when paths have dots.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/f6214904f359c13d9699345837253b46c6dce336/after/5e42b162a8fa1ed9036fa58b85a36ae25f46278e@github.com>

Aaron B

unread,
6:40 PM (3 hours ago) 6:40 PM
to vim/vim, Push

@7188ce06 pushed 1 commit.

  • 8d1e623 Make tar extraction work when paths have dots.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/before/b5f747f5309ea35bb5be885b7dea812d9fc9dfeb/after/8d1e6239c59440ce9b2a85c6f6ecf8777aff0720@github.com>

Aaron B

unread,
6:43 PM (3 hours ago) 6:43 PM
to vim/vim, Subscribed
7188ce06 left a comment (vim/vim#19930)

@chrisbra Do you have any comments on this?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19930/c4202641729@github.com>

Reply all
Reply to author
Forward
0 new messages