[vim/vim] Link Scala highlighting groups using 'hi def link' (PR #9594)

4 views
Skip to first unread message

Job Noorman

unread,
Jan 22, 2022, 7:16:13 AMJan 22
to vim/vim, Subscribed

They were linked using 'hi link' which made it impossible for color schemes to override highlight groups.

See this issue for example.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/9594

Commit Summary

  • ba1630a Link Scala highlighting groups using 'hi def link'

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9594@github.com>

Bram Moolenaar

unread,
Jan 22, 2022, 7:36:46 AMJan 22
to vim/vim, Subscribed

The header mentions https://github.com/derekwyatt/vim-scala
@derekwyatt


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9594/c1019236475@github.com>

Derek Wyatt

unread,
Jan 22, 2022, 4:54:07 PMJan 22
to vim/vim, Subscribed

LGTM. We can port this back to the source location.


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9594/c1019364389@github.com>

codecov[bot]

unread,
Feb 14, 2022, 12:53:37 PMFeb 14
to vim/vim, Subscribed

Codecov Report

Merging #9594 (ba1630a) into master (b697dc2) will decrease coverage by 81.47%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@

##           master    #9594       +/-   ##

===========================================

- Coverage   83.51%    2.03%   -81.48%     

===========================================

  Files         154      152        -2     

  Lines      174446   168774     -5672     

  Branches    39247    39066      -181     

===========================================

- Hits       145687     3435   -142252     

- Misses      16665   164650   +147985     

+ Partials    12094      689    -11405     
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests 2.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/libvterm/src/rect.h 0.00% <0.00%> (-96.78%) ⬇️
src/libvterm/src/parser.c 0.00% <0.00%> (-95.89%) ⬇️
src/sha256.c 0.00% <0.00%> (-94.90%) ⬇️
src/gui_gtk_f.c 0.00% <0.00%> (-94.72%) ⬇️
src/crypt_zip.c 0.00% <0.00%> (-94.12%) ⬇️
src/debugger.c 0.00% <0.00%> (-92.20%) ⬇️
src/float.c 0.00% <0.00%> (-91.38%) ⬇️
src/ex_docmd.c 0.00% <0.00%> (-91.33%) ⬇️
src/evalfunc.c 0.00% <0.00%> (-91.16%) ⬇️
src/evalbuffer.c 0.00% <0.00%> (-91.02%) ⬇️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b697dc2...ba1630a. Read the comment docs.


Reply to this email directly, view it on GitHub, or unsubscribe.


Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9594/c1039379497@github.com>

Reply all
Reply to author
Forward
0 new messages