[vim/vim] [Termdebug] E239 Invalid sign text: 100 (when breakpoint id is greater than 99) (Issue #12588)

Linwei

unread,

Jun 25, 2023, 12:54:33 AM6/25/23

to vim/vim, Subscribed

Steps to reproduce

start debug some file
in the source window, call Break and Clear x 100 times

Expected behaviour

sign columns seem only accept text with-in 2 characters.

breakpointer id greater than 99 will trigger this issue.

Version of Vim

9.0.1664

Environment

OS: Windows
TERM: cmd.exe

Logs and stack traces

Breakpoint 89 cleared from line 8.
Breakpoint 90 created at line 8.
Breakpoint 90 cleared from line 8.
Breakpoint 91 created at line 8.
Breakpoint 91 cleared from line 8.
Breakpoint 92 created at line 8.
Breakpoint 92 cleared from line 8.
Breakpoint 93 created at line 8.
Breakpoint 93 cleared from line 8.
Breakpoint 94 created at line 8.
Breakpoint 94 cleared from line 8.
Breakpoint 95 created at line 8.
Breakpoint 95 cleared from line 8.
Breakpoint 96 created at line 8.
Breakpoint 96 cleared from line 8.
Breakpoint 97 created at line 8.
Breakpoint 97 cleared from line 8.
Breakpoint 98 created at line 8.
Breakpoint 98 cleared from line 8.
Breakpoint 99 created at line 8.
Breakpoint 99 cleared from line 8.
Error detected while processing function <SNR>146_GdbOutCallback[18]..<SNR>146_CommOutput[15]..<SNR>146_HandleNewBreakpoint[24]..<SNR>146_CreateBreakpoint:
line    9:
E239: Invalid sign text: 100
Breakpoint 100 created at line 8.
E239: Invalid sign text: 101
Breakpoint 101 created at line 8.
Press ENTER or type command to continue

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Linwei

unread,

Jun 25, 2023, 1:15:53 AM6/25/23

to vim/vim, Subscribed

what about change the sign text to a <> (diamond) ?

Breakpoint id greater than 99 can be represented as a <> or BR or BB

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Linwei

unread,

Jun 25, 2023, 2:45:25 AM6/25/23

to vim/vim, Subscribed

or display a label defined in g:termdebug_config["label"] (default to BB) as an alternative to breakpoint id ?

the exact breakpoint id can still be queried by info break in the gdb window.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Linwei

unread,

Jun 25, 2023, 3:28:04 AM6/25/23

to vim/vim, Subscribed

I have created a PR for this: #12589

fix:

always display the last two characters of the breakpoint id, and id 133 will display as 33.
if g:termdebug_config['label'] is defined by user, display it in the signcolumn instead of the the breakpoint id.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Jun 28, 2023, 6:28:15 PM6/28/23

to vim/vim, Subscribed

Closed #12588 as completed via e7d9ca2.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward