Re: [vim/vim] VisualNOS not used when Wayland selection ownership lost (PR #20066)

[Shane Harper]

shaneharper left a comment (vim/vim#20066)

• I tested on Arch Linux with the Wayfire Wayland compositor.
• I have made a minimal update to runtime/doc/syntax.txt. I plan to submit a separate patch with improvements to wording.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20066/c4319551198@github.com>

[Shane Harper]

Problem: VisualNOS not used when Wayland selection ownership lost (lilydjwg)
Solution: Don't require X_DISPLAY != NULL to use VisualNOS (Shane Harper).

fixes: #19914
related: #19812, #19659

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20066

Commit Summary

• 339d1a7 VisualNOS not used when Wayland selection ownership lost
• aa9f0f5 Don't require FEAT_X11 to use VisualNOS.

File Changes

(2 files)

• M runtime/doc/syntax.txt (3)
• M src/drawline.c (9)

Patch Links:

• https://github.com/vim/vim/pull/20066.patch
• https://github.com/vim/vim/pull/20066.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20066@github.com>

[依云]

lilydjwg left a comment (vim/vim#20066)

Yes, it works for me.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20066/c4319778521@github.com>

[Shane Harper]

shaneharper left a comment (vim/vim#20066)

The last change was to avoid compiling dead code.

-#ifdef FEAT_CLIPBOARD
+#if defined(FEAT_CLIPBOARD) && (defined(FEAT_X11) || defined(FEAT_WAYLAND_CLIPBOARD))

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20066/c4320873158@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#20066)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20066/c4330006126@github.com>

[Christian Brabandt]

Closed #20066 via 7e76514.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20066/issue_event/24921010885@github.com>