[vim/vim] Wrong padding for pum "kind" with 'rightleft' (PR #15004)

7 views
Skip to first unread message

zeertzjq

unread,
Jun 14, 2024, 8:21:07 PM (13 days ago) Jun 14
to vim/vim, Subscribed

Problem: Wrong padding for pum "kind" with 'rightleft'.
Solution: Fix off-by-one error.

The screen_fill() above is end-exclusive, and

  • With 'rightleft' it fills pum_col - pum_base_width - n + 1 to col,
    so the next col should be pum_col - pum_base_width - n.
  • With 'norightleft' it fills col to pum_col - pum_base_width + n - 1,
    so the next col should be pum_col - pum_base_width + n.

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/15004

Commit Summary

  • 99e1319 Wrong padding for pum "kind" with 'rightleft'

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15004@github.com>

Christian Brabandt

unread,
Jun 15, 2024, 9:07:37 AM (12 days ago) Jun 15
to vim/vim, Subscribed

thanks!


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15004/c2169558238@github.com>

Christian Brabandt

unread,
Jun 15, 2024, 9:10:23 AM (12 days ago) Jun 15
to vim/vim, Subscribed

Closed #15004 via a232437.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15004/issue_event/13169109747@github.com>

Reply all
Reply to author
Forward
0 new messages