[vim/vim] Still buffer overflow. (PR #19411)

[mattn]

@chrisbra I suspect this fix does not fully resolve the issue.

c5f312a#diff-012c27cfc933c3fb6030c48e84f44e5cd2706af0b1ac94631f6a5d31b13170b0R2322

• keybuf[KEYBUFLEN] is a fixed-size buffer of 64 bytes (KEYBUFLEN = 64)
• strlen(tok) returns the string length (NUL terminator not included)
• i is the number of characters already written to keybuf

After copying, we need 1 additional byte for the NUL terminator (\0). And the original check strlen(tok) + i < 64 only checked up to 63 bytes.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19411

Commit Summary

• 7b4eabc Still buffer overflow.

File Changes

(1 file)

• M src/netbeans.c (4)

Patch Links:

• https://github.com/vim/vim/pull/19411.patch
• https://github.com/vim/vim/pull/19411.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19411@github.com>