[vim/vim] Popup window with title is flickering on gVim.exe (#7334)
24 views
Skip to first unread message
Naruhiko Nishino
Nov 20, 2020, 5:40:25 AM11/20/20
to vim/vim, Subscribed
This PR will be fix the flickering.
before
after
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/7334
Commit Summary
- fix
File Changes
- M src/popupwin.c (51)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Christ van Willegen
Nov 20, 2020, 5:58:52 AM11/20/20
to vim...@googlegroups.com, reply+ACY5DGDQUAWZ5EVUV5...@reply.github.com
This PR will be fix the flickering.
+ if (0 < title_len)
+ {Personally, I find this inverted condition hard to read. Could you change it to tl>0?
Thanks!
Christ van Willegen
vim-dev ML
Nov 20, 2020, 5:59:16 AM11/20/20
to vim/vim, vim-dev ML, Your activity
> This PR will be fix the flickering.
>
>
+ if (0 < title_len)
+ {
Personally, I find this inverted condition hard to read. Could you
change it to tl>0?
Thanks!
Christ van Willegen
+ {
Personally, I find this inverted condition hard to read. Could you
change it to tl>0?
Thanks!
Christ van Willegen
Naruhiko Nishino
Nov 20, 2020, 6:14:38 AM11/20/20
to vim/vim, vim-dev ML, Comment
Personally, I find this inverted condition hard to read. Could you
change it to tl>0?Thanks!
Christ van Willegen
Thank you for this reviewing. I fixed the inverted condition.
—
You are receiving this because you commented.
Bram Moolenaar
Nov 20, 2020, 6:23:50 AM11/20/20
to vim/vim, vim-dev ML, Comment
Any relation with #7317 ? Or are the two completely separate?
—
You are receiving this because you commented.
Naruhiko Nishino
Nov 20, 2020, 6:36:20 AM11/20/20
to vim/vim, vim-dev ML, Comment
These are the two completely separate.
—
You are receiving this because you commented.
0 new messages