[vim/vim] Add `status_height` to the dict items returned by `getwininfo()` (PR #18841)
h_east
I think it's strange that this hasn't existed until now.
(In addition, the order of items in the getwininfo() documentation has been changed to alphabetical order)
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18841
Commit Summary
- ca41148 Add `status_height` to the dict items returned by `getwininfo()`
File Changes
(3 files)
- M runtime/doc/builtin.txt (9)
- M src/evalwindow.c (1)
- M src/testdir/test_bufwintabinfo.vim (22)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
> @@ -5343,9 +5343,13 @@ getwininfo([{winid}]) *getwininfo()*
{only with the +quickfix feature}
quickfix 1 if quickfix or location list window
{only with the +quickfix feature}
+ status_height status lines height (0 or 1)
But this is not really the height, but rather whether a statusline is displayed, so
shouldn't that be rather:
- status_height status lines height (0 or 1) + statusline window has a status line displayed (0 or 1)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east commented on this pull request.
> @@ -5343,9 +5343,13 @@ getwininfo([{winid}]) *getwininfo()*
{only with the +quickfix feature}
quickfix 1 if quickfix or location list window
{only with the +quickfix feature}
+ status_height status lines height (0 or 1)
At the moment it is, but I'm working on a multi-line-statusline patch.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
> @@ -5343,9 +5343,13 @@ getwininfo([{winid}]) *getwininfo()*
{only with the +quickfix feature}
quickfix 1 if quickfix or location list window
{only with the +quickfix feature}
+ status_height status lines height (0 or 1)
okay, but then we would have an entry statusline which indicates whether the window has a statusline and stl_height which gives the line height, no?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east commented on this pull request.
> @@ -5343,9 +5343,13 @@ getwininfo([{winid}]) *getwininfo()*
{only with the +quickfix feature}
quickfix 1 if quickfix or location list window
{only with the +quickfix feature}
+ status_height status lines height (0 or 1)
I think a single entry is sufficient. A value of 0 means no statusline. Any other value specifies the statusline’s height. Negative values are not allowed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18841)okay, fair thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#18841)Thanks for the merging. There may be room to discuss the item name status_height:
stl_heightstatusline
…
Does anyone have any thoughts?
(Please take into account that in the near future, integers other than 0 and 1 may be specified)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.