[vim/vim] runtime(progress): Use setlocal for expandtab (PR #19458)
Daniel Smith
The Progress syntax file gained set expandtab in 4c3f536 (updated for version 7.0d01, 2006-04-11). The Progress language itself doesn't distinguish between tabs and spaces for indentation, so this seems like something that should be left to user preference; but the setting is accompanied by the comment "The Progress editor doesn't cope with tabs very well", so there may be reason to keep it.
However, using set means that any new buffers created after editing a Progress file will also have expandtab turned on, which is likely contrary to a user's expectations. We should use setlocal instead to avoid this.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19458
Commit Summary
- 801671c runtime(progress): Use setlocal for expandtab
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Daniel Smith
rdnlsmith left a comment (vim/vim#19458)This addresses #19449 with respect to the named example, progress.vim. There may or may not be other syntax files using set where setlocal might be more appropriate.
I tried to run tests, but I got a test failure before I even changed anything:
Run 5, 18:56:33 - 18:56:48 in 15.010923 seconds:
command line..script /home/daniel/code/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_server_stopinsert[28]..WaitForAssert[2]..<SNR>4_WaitForCommon[11]..<lambda>30 line 1: Expected 'n' but got 'i'
command line..script /home/daniel/code/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_server_stopinsert[29]..WaitForAssert[2]..<SNR>4_WaitForCommon[11]..<lambda>31 line 1: Expected '13' but got '14'
command line..script /home/daniel/code/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_server_stopinsert[33]..WaitForAssert[2]..<SNR>4_WaitForCommon[11]..<lambda>32 line 1: Expected 'dead' but got 'run'
command line..script /home/daniel/code/vim/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_client_server_stopinsert line 36: Server did not exit
Flaky test failed too often, giving up
TEST FAILURE
make[1]: *** [Makefile:53: report] Error 1
make[1]: Leaving directory '/home/daniel/code/vim/src/testdir'
make: *** [Makefile:2203: scripttests] Error 2
It's been a while since my last contribution, so it's possible I missed something. I also don't remember if there's a way to run just the syntax tests.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19458)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.