[vim/vim] GTK4: input method cannot compose text (PR #20266)
mattn
GTK4 GUI cannot use an input method to compose text: the IM popup appears for a moment and immediately disappears.
The previous code attached the key event controller to gui.mainwin and called gtk_im_context_filter_keypress() manually inside key_press_event(). In GTK4 that does not work reliably with GtkEventControllerKey.
This change attaches the key controller to gui.drawarea and binds the IM context to the controller via gtk_event_controller_key_set_im_context(). GTK4 then routes key events through the IM automatically (preedit/commit signals fire, and key-pressed is suppressed when the IM consumes the key), so the manual gtk_im_context_filter_keypress() call is no longer needed.
Fixes #20257
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20266
Commit Summary
- ac5d399 GTK4: input method cannot compose text
File Changes
(1 file)
- M src/gui_gtk4.c (29)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 60ad7a5 GTK4: preedit toplevel breaks Wayland input method
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 2558787 GTK4: fold xim_init() into gui_mch_init()
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 2f6a48a GTK4: wire 'imstyle' to the Wayland PREEDIT_SHOWN content hint
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 944fc1d GTK4: re-implement IM_OVER_THE_SPOT preedit with GtkPopover
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- f047813 GTK4: fix SEGV on startup from xim_init() cursor-location seed
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20266)@lilydjwg does this fix your issue?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
依云
lilydjwg left a comment (vim/vim#20266)@chrisbra we are discussing at the original issue. (I'm not sure whether the discussion should move from issue to pr. I didn't for my recent issues.)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 3873161 GTK4: align imstyle=1 preedit popover with cursor cell
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.