[vim/vim] Fix document index.txt and windows.txt (PR #16357)

25 views
Skip to first unread message

h_east

unread,
Jan 1, 2025, 10:41:30 AMJan 1
to vim/vim, Subscribed

Related: #16356
Modified documentation based on results of running "$ make check_doc" with improved generator script.

Regarding the notation of shortened commands, index.txt has been corrected all. However, for other documents, only the ones that were obviously incorrect have been corrected.
Corrected:

  • :hor[izontal] ---> :ho[rizontal]
  • :pta[g] ---> :pt[ag]

Not corrected (for example):

  • :bufdo ---> :bufd[o]
  • :eval ---> :ev[al]

Reasons for not correcting:

  • Vim9 script is moving in a direction away from shortening. (:h vim9-no-shorten)
  • When written as :ev[al], people's psychology dictates that they will shorten the command.

There may be room for discuss, but I would like to proceed in this direction.

--Best regards,
Hirohito Higashi (h_east)


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/16357

Commit Summary

  • 4162b17 Fix document index.txt and windows.txt

File Changes

(3 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357@github.com>

Aliaksei Budavei

unread,
Jan 1, 2025, 12:23:00 PMJan 1
to vim/vim, Subscribed

@zzzyxwvut commented on this pull request.


In runtime/doc/index.txt:

> @@ -1185,6 +1185,7 @@ tag		command		action ~
 |:abbreviate|	:ab[breviate]	enter abbreviation
 |:abclear|	:abc[lear]	remove all abbreviations
 |:aboveleft|	:abo[veleft]	make split window appear left or above
+|:abstract|	:abstract	define a Vim9 abstract class
⬇️ Suggested change
-|:abstract|	:abstract	define a Vim9 abstract class
+|:abstract|	:abstract	declare an abstract class


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/review/2526902635@github.com>

Aliaksei Budavei

unread,
Jan 1, 2025, 12:23:08 PMJan 1
to vim/vim, Subscribed

@zzzyxwvut commented on this pull request.


In runtime/doc/index.txt:

> @@ -1338,12 +1339,15 @@ tag		command		action ~
 |:emenu|	:em[enu]	execute a menu by name
 |:endclass|	:endclass	end of a class specification
 |:enddef|	:enddef		end of a user function started with :def
+|:endenum|	:endenum	end of a enum specification
⬇️ Suggested change
-|:endenum|	:endenum	end of a enum specification
+|:endenum|	:endenum	end of an enum specification


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/review/2526902654@github.com>

Aliaksei Budavei

unread,
Jan 1, 2025, 12:23:11 PMJan 1
to vim/vim, Subscribed

@zzzyxwvut commented on this pull request.


In runtime/doc/index.txt:

>  |:endfor|	:endfo[r]	end previous :for
 |:endfunction|	:endf[unction]	end of a user function started with :function
 |:endtry|	:endt[ry]	end previous :try
 |:endwhile|	:endw[hile]	end previous :while
 |:enew|		:ene[w]		edit a new, unnamed buffer
+|:enum|		:enum		start of a enum specification
⬇️ Suggested change
-|:enum|		:enum		start of a enum specification
+|:enum|		:enum		start of an enum specification


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/review/2526902672@github.com>

Aliaksei Budavei

unread,
Jan 1, 2025, 12:23:52 PMJan 1
to vim/vim, Subscribed

@zzzyxwvut commented on this pull request.


In runtime/doc/index.txt:

> @@ -1706,6 +1711,7 @@ tag		command		action ~
 |:terminal|	:ter[minal]	open a terminal window
 |:tfirst|	:tf[irst]	jump to first matching tag
 |:throw|	:th[row]	throw an exception
+|:this|		:this		prefix for an object member

this is a reference to an object instantiated with new();
this reference is only permitted in the bodies of instance
methods, constructors, and instance variable initializers
(with some further restrictions, see #14411).


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/review/2526902747@github.com>

Aliaksei Budavei

unread,
Jan 1, 2025, 12:26:39 PMJan 1
to vim/vim, Subscribed

I would've rather used ‘declaration’ throughout for every
‘specification’. Since we have incomplete types that are
introduced with either :interface or :abstract class and
complete types (classes and enums); we can use an umbrella
term ‘declaration’ for either. There is also an undeveloped
‘specifies’ concept (#15440) that may further complicate
type-related terminology in the future.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/c2567086180@github.com>

h_east

unread,
Jan 1, 2025, 1:21:34 PMJan 1
to vim/vim, Subscribed

Thanks for reviewing.
Most of the explanations for the added lines are copied from doc/version9.txt.

:h added-9.1
/:abs

https://github.com/vim/vim/blob/8dc98bf427d62501d9ecbb48d20ae2633c3db187/runtime/doc/version9.txt#L31852-L31863

If you are concerned, you can modify the original descriptions.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/c2567101702@github.com>

h_east

unread,
Jan 1, 2025, 1:22:04 PMJan 1
to vim/vim, Push

@h-east pushed 1 commit.

  • 0086e3b Update runtime/doc/index.txt


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/before/4162b17d695100ce8934418e23a7b514181ca16d/after/0086e3b82c94c9739bb958536a759d7e62d197de@github.com>

h_east

unread,
Jan 1, 2025, 1:22:11 PMJan 1
to vim/vim, Push

@h-east pushed 1 commit.

  • d6813d7 Update runtime/doc/index.txt

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/before/0086e3b82c94c9739bb958536a759d7e62d197de/after/d6813d70f2080c8348a8da3d58deedacbfc654a3@github.com>

Christian Brabandt

unread,
Jan 2, 2025, 4:45:48 AMJan 2
to vim/vim, Subscribed

Thanks, I'll also update it with @zzzyxwvut suggestions.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/c2567504151@github.com>

zeertzjq

unread,
Jan 2, 2025, 5:02:44 AMJan 2
to vim/vim, Subscribed

:ho doesn't work for parse_command_modifiers():

	    case 'h':	if (checkforcmd_noparen(&eap->cmd, "horizontal", 3))
			{
			    cmod->cmod_split |= WSP_HOR;
			    continue;
			}


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/c2567524455@github.com>

Christian Brabandt

unread,
Jan 2, 2025, 5:05:57 AMJan 2
to vim/vim, Subscribed

Closed #16357 via 0c3e57b.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/issue_event/15797183371@github.com>

h_east

unread,
Jan 2, 2025, 5:31:04 AMJan 2
to vim/vim, Subscribed

@zeertzjq Oops, I'll fix this. new PR?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/c2567559016@github.com>

h_east

unread,
Jan 2, 2025, 5:58:23 AMJan 2
to vim/vim, Subscribed

PRed. #16362


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16357/c2567592732@github.com>

Reply all
Reply to author
Forward
0 new messages