[vim/vim] runtime(filetype): recognize more Ruby files (PR #18697)

[Anton Melnikov]

rbi is a file extension used by Sorbet, typechecker for Ruby: https://sorbet.org/docs/rbi

Brewfile is a bundler file for Homebrew package manager: https://docs.brew.sh/Brew-Bundle-and-Brewfile

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18697

Commit Summary

• b7bc6fb runtime(filetype): recognize more Ruby files

File Changes

(2 files)

• M runtime/autoload/dist/ft.vim (4)
• M src/testdir/test_filetype.vim (2)

Patch Links:

• https://github.com/vim/vim/pull/18697.patch
• https://github.com/vim/vim/pull/18697.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18697@github.com>

[Andrew Radev]

AndrewRadev left a comment (vim/vim#18697)

Hmm, ordinarily I would say you should make this PR to the vim-ruby project: https://github.com/vim-ruby/vim-ruby. This is occasionally merged upstream, which is how the shipped runtime files get updated. But Sorbet support is already present there since 2020: vim-ruby/vim-ruby@07e8c85

I see that the upstream runtime files were missing support for .rbi even before the conversion to the new autoloaded detection mechanism: 3221a0c#diff-c07c0771a9f5af08e375703487a8fe7bbddd71f98a7bbe06acd78365525a243e. Maybe they were just missed, or maybe an executive decision has been made to filter them out or something? @dkearns, do you know why .rbi detection is missing upstream?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18697/c3506689490@github.com>

[dkearns]

dkearns left a comment (vim/vim#18697)

Back when Ruby was cooler with the kids than it is these days, the ftdetect updates were coming thick and fast and we decided to only submit those that were considered part of the core language ecosystem (roughly) for distribution with Vim. That's why there's two ftdetect files, the entries in ruby_extra.vim didn't make it into the Vim.

Vim's accepting pretty much anything these days for file detection so I guess we should look at adding ruby_extra.vim as well.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18697/c3512957235@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#18697)

So this is still work in progress?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18697/c3513720551@github.com>

[dkearns]

dkearns left a comment (vim/vim#18697)

No, this can be merged now. I'll look at adding some more soon.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18697/c3515013500@github.com>

[dkearns]

@dkearns approved this pull request.

Thanks @botantony

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18697/review/3446266760@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#18697)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18697/c3517982302@github.com>

[Christian Brabandt]

Closed #18697 via efc3be7.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18697/issue_event/20868075696@github.com>