[vim/vim] Is it possible to restore Catppuccin SpellBad to its previous value? (Issue #21428)

ubaldot

unread,

3:24 AM (13 hours ago) 3:24 AM

to vim/vim, Subscribed

ubaldot created an issue (vim/vim#21428)

I have updated Vim, and now I found the SpellBad higroup in catppuccin colorscheme a bit too invasive.
Before, the higroup only added a wiggled red (or blue) line under the word, like in the following picture:

Image: Image (view on web)

Now, it make the whole word red, see next picture:

Image: Image (view on web)

Would that be possible to revert the change?
The previous version seems also to be more standardized (see e.g. how GitHub itself marks spell errors).

Thanks.

@habamax

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

3:28 AM (12 hours ago) 3:28 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#21428)

Is it GUI?

current catppuccin in vim/colorschemes

Image: Image (view on web) Image: Image (view on web)

I am not sure if vim has the latest version though

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

3:30 AM (12 hours ago) 3:30 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#21428)

if it is TUI and you have your terminal with undercurl then it is not colorscheme, vim can't render underline/undercurl with a different color then the text it under(line|curl)s

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

3:33 AM (12 hours ago) 3:33 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#21428)

cc @mao-yining

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Mao-Yining

unread,

3:37 AM (12 hours ago) 3:37 AM

to vim/vim, Subscribed

mao-yining left a comment (vim/vim#21428)

You are using TUI right? Which terminal you are using?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Mao-Yining

unread,

3:42 AM (12 hours ago) 3:42 AM

to vim/vim, Subscribed

mao-yining left a comment (vim/vim#21428)

You are using TUI right? Which terminal you are using?

No. Only GUI is using undercurl in current catppuccin. What is the version of you GUI? And what platform are you using?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

3:49 AM (12 hours ago) 3:49 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#21428)

if it is TUI and you have your terminal with undercurl then it is not colorscheme, vim can't render underline/undercurl with a different color than the text it under(line|curl)s

ctermul={color-nr}				*highlight-ctermul*
	These give the foreground (ctermfg), background (ctermbg) and
	underline (ctermul) color to use in the terminal.

	The {color-nr} argument is a color number.  Its range is zero to
	(not including) the number given by the termcap entry "Co".
	The actual color with this number depends on the type of terminal
	and its settings.  Sometimes the color also depends on the settings of
	"cterm".  For example, on some systems "cterm=bold ctermfg=3" gives
	another color, on others you just get color 3.

Although I couldn't change the color, it always follow ctermfg/guifg.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

ubaldot

unread,

5:05 AM (11 hours ago) 5:05 AM

to vim/vim, Subscribed

ubaldot left a comment (vim/vim#21428)

Sorry, I haven't specified: GVIM on Windows 11.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

5:08 AM (11 hours ago) 5:08 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#21428)

Sorry, I haven't specified: GVIM with patch 1161 on Windows 11.

The latest version (which is in the latest windows vim build) of catppuccin defines:

  hi SpellBad guifg=NONE guibg=NONE guisp=#d20f39 gui=undercurl ctermfg=161 ctermbg=NONE cterm=underline term=underline

Which is what you can see in my previous screenshots -- only undercurl is colored.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

5:10 AM (11 hours ago) 5:10 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#21428)

Ah, do not set termguicolors for gvim.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Mao-Yining

unread,

5:10 AM (11 hours ago) 5:10 AM

to vim/vim, Subscribed

mao-yining left a comment (vim/vim#21428)

> Sorry, I haven't specified: GVIM on Windows 11.

Can't reproduce. Use `gvim --clean` and try again please?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

ubaldot

unread,

5:10 AM (11 hours ago) 5:10 AM

to vim/vim, Subscribed

ubaldot left a comment (vim/vim#21428)

That is very strange: when I read line 566 of the bundled catppuccin file I have the following:

hi SpellBad guifg=#d20f39 guibg=NONE ctermfg=161 ctermbg=NONE cterm=underline

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Mao-Yining

unread,

5:14 AM (11 hours ago) 5:14 AM

to vim/vim, Subscribed

mao-yining left a comment (vim/vim#21428)

Ah, do not set termguicolors for gvim.

Maybe a !has('gui_running') is needed.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Mao-Yining

unread,

5:16 AM (11 hours ago) 5:16 AM

to vim/vim, Subscribed

mao-yining left a comment (vim/vim#21428)

CC: @lifepillar Do you think that is needed to use a !has('gui_running') for termguicolor to avoid situation like this?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

ubaldot

unread,

5:18 AM (11 hours ago) 5:18 AM

to vim/vim, Subscribed

ubaldot left a comment (vim/vim#21428)

Ah, do not set termguicolors for gvim.

This fixes.
However, I tried to keep set termguicolors in .vimrc and then set notermguicolors in .gvimrc, being .gvimrc sourced after .vimrc but it didn't work. The only way is to do not set termguicolor at all. However, it would be nice if the issue is set upstream.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

5:20 AM (11 hours ago) 5:20 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#21428)

However, I tried to keep set termguicolors in .vimrc and then set notermguicolors in .gvimrc, being .gvimrc sourced after .vimrc but

if !has("gui_running")
    set termguicolors
endif

There is a dependency on colortemplate plugin by @lifepillar (not sure if he is on github and ping would work or completely moved to codeberg and we will need to reach him my mail)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Lifepillar

unread,

5:27 AM (10 hours ago) 5:27 AM

to vim/vim, Subscribed

lifepillar left a comment (vim/vim#21428)

I'm still here, and I do get notified by email when pinged. I'll check this asap.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Lifepillar

unread,

6:22 AM (10 hours ago) 6:22 AM

to vim/vim, Subscribed

lifepillar left a comment (vim/vim#21428)

I think that it makes sense to use termguicolors overrides only when has('gui_running') is false (I hope I'm not missing anything, the termguicolors stuff is a bit tricky to get right).

This should be fixed in Colortemplate v3.0.0-rc3, which you may get by updating your vim-devel package. I haven't tested it against this specific issue, though.

For the OP, the only difference that the fix makes to the generated color scheme is that this line:

let s:tgc = has('termguicolors') && &termguicolors

becomes

let s:tgc = has('termguicolors') && &termguicolors && !has('gui_running')

Let us know if this change solves your problem.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

6:39 AM (9 hours ago) 6:39 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#21428)

Thanks @lifepillar

Colorschemes in vim/colorschemes are regenerated with new colortemplate version.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward