[vim/vim] Fix clang compiler warnings in the MS-Windows build (PR #10538)
Yegappan Lakshmanan
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10538
Commit Summary
- b3c0fd1 Fix clang compiler warnings in the MS-Windows build
File Changes
(5 files)
- M src/dosinst.c (2)
- M src/fileio.c (1)
- M src/gui_w32.c (5)
- M src/os_mswin.c (2)
- M src/os_win32.c (2)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #10538 (b3c0fd1) into master (aca12fd) will increase coverage by
0.88%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #10538 +/- ## ========================================== + Coverage 81.67% 82.56% +0.88% ========================================== Files 158 148 -10 Lines 185324 172684 -12640 Branches 41909 39049 -2860 ========================================== - Hits 151372 142583 -8789 + Misses 21502 17518 -3984 - Partials 12450 12583 +133
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.56% <ø> (+<0.01%) |
⬆️ |
| linux | 82.56% <ø> (+<0.01%) |
⬆️ |
| mingw-x64-HUGE | ? |
|
| mingw-x64-HUGE-gui | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/fileio.c | 75.28% <ø> (-0.66%) |
⬇️ |
| src/highlight.c | 78.69% <0.00%> (-2.70%) |
⬇️ |
| src/time.c | 87.08% <0.00%> (-2.56%) |
⬇️ |
| src/misc2.c | 86.38% <0.00%> (-2.52%) |
⬇️ |
| src/buffer.c | 84.15% <0.00%> (-2.39%) |
⬇️ |
| src/help.c | 80.07% <0.00%> (-2.38%) |
⬇️ |
| src/gui.c | 71.05% <0.00%> (-2.08%) |
⬇️ |
| src/libvterm/src/screen.c | 51.96% <0.00%> (-2.04%) |
⬇️ |
| src/session.c | 63.15% <0.00%> (-1.94%) |
⬇️ |
| src/menu.c | 81.03% <0.00%> (-1.86%) |
⬇️ |
| ... and 130 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update aca12fd...b3c0fd1. Read the comment docs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
K.Takata
@k-takata commented on this pull request.
In src/dosinst.c:
> @@ -212,7 +212,7 @@ check_unpack(void)
printf("ERROR: Cannot find filetype.vim in \"%s\"\n", installdir);
printf("It looks like you did not unpack the runtime archive.\n");
printf("You must unpack the runtime archive \"vim%srt.zip\" before installing.\n",
If line 215 is changed from VIM_VERSION_NODOT + 3 to VIM_VERSION_NODOT, then this line should be changed as follows:
- printf("You must unpack the runtime archive \"vim%srt.zip\" before installing.\n",
+ printf("You must unpack the runtime archive \"%srt.zip\" before installing.\n",
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan pushed 1 commit.
- d88bae4 Update error message
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@k-takata commented on this pull request.
In src/dosinst.c:
> @@ -212,7 +212,7 @@ check_unpack(void) printf("ERROR: Cannot find filetype.vim in \"%s\"\n", installdir); printf("It looks like you did not unpack the runtime archive.\n"); printf("You must unpack the runtime archive \"vim%srt.zip\" before installing.\n",If line 215 is changed from
VIM_VERSION_NODOT + 3toVIM_VERSION_NODOT, then this line should be changed as follows:
⬇️ Suggested change- printf("You must unpack the runtime archive \"vim%srt.zip\" before installing.\n", + printf("You must unpack the runtime archive \"%srt.zip\" before installing.\n",
vim-dev ML
On Tue, Jun 7, 2022 at 7:52 PM K.Takata ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In src/dosinst.c
> <https://github.com/vim/vim/pull/10538#discussion_r891868223>:
>
> > @@ -212,7 +212,7 @@ check_unpack(void)
>
> printf("ERROR: Cannot find filetype.vim in \"%s\"\n", installdir);
>
> printf("It looks like you did not unpack the runtime archive.\n");
>
> printf("You must unpack the runtime archive \"vim%srt.zip\" before installing.\n",
>
>
> If line 215 is changed from VIM_VERSION_NODOT + 3 to VIM_VERSION_NODOT,
> then this line should be changed as follows:
>
VIM_VERSION_NODOT is defined as a string. The current code is trying to add
a number to the string.
> ⬇️ Suggested change
>
> - printf("You must unpack the runtime archive \"vim%srt.zip\" before installing.\n",
>
> + printf("You must unpack the runtime archive \"%srt.zip\" before installing.\n",
>
>
>
>
Updated the PR with this change.
- Yegappan
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
K.Takata
VIM_VERSION_NODOT is defined as a string. The current code is trying to add
a number to the string.
Yes, it was intended. VIM_VERSION_NODOT is "vim82". Adding 3 to it means that the pointer points to the third character of the string. So, VIM_VERSION_NODOT + 3 is the same as "82".
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
Bram Moolenaar
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.