[vim/vim] fix: make gf extract packadd/colo name more flexible (PR #17983)

Shane-XB-Qian

unread,

Aug 13, 2025, 4:41:07 AM8/13/25

to vim/vim, Subscribed

e.g colo foo | echo 'bar'

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/17983

Commit Summary

1143d5d fix: make gf extract packadd/colo name more flexible

File Changes

(1 file)

M runtime/autoload/vimgoto.vim (4)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 13, 2025, 5:23:22 AM8/13/25

to vim/vim, Subscribed

@chrisbra commented on this pull request.

In runtime/autoload/vimgoto.vim:

> @@ -39,7 +39,7 @@ enddef
 #}}}1
 # Core {{{1
 def HandlePackaddLine(editcmd: string, curline: string) #{{{2
-    var pat: string = '^\s*\%(:\s*\)\=packadd!\=\s\+\zs\S\+$'
+    var pat: string = '\s*\%(:\s*\)\=packadd!\=\s\+\zs\S\+\ze'

⬇️ Suggested change

-    var pat: string = '\s*\%(:\s*\)\=packadd!\=\s\+\zs\S\+\ze'
+    var pat: string = '\s*\%(:\s*\)\=packadd!\=\s\+\zs\S\+\>\ze'

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Shane-XB-Qian

unread,

Aug 13, 2025, 5:34:45 AM8/13/25

to vim/vim, Push

@Shane-XB-Qian pushed 1 commit.

0d5678a fix: make gf extract packadd/colo name more flexible

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Shane-XB-Qian

unread,

Aug 13, 2025, 5:35:22 AM8/13/25

to vim/vim, Subscribed

@Shane-XB-Qian commented on this pull request.

In runtime/autoload/vimgoto.vim:

> @@ -39,7 +39,7 @@ enddef
 #}}}1
 # Core {{{1
 def HandlePackaddLine(editcmd: string, curline: string) #{{{2
-    var pat: string = '^\s*\%(:\s*\)\=packadd!\=\s\+\zs\S\+$'
+    var pat: string = '\s*\%(:\s*\)\=packadd!\=\s\+\zs\S\+\ze'

ok, thx.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 13, 2025, 4:30:52 PM8/13/25

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#17983)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 13, 2025, 4:32:44 PM8/13/25

to vim/vim, Subscribed

Closed #17983 via dd9ed09.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward