[vim/vim] fix #487 (PR #18331)

[Damien Lejay]

Fix #487

(touch test.txt)

is now correctly painted.

• (...) is not an arithmetic region but a sub shell
• test here is not a keyword.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18331

Commit Summary

• ba8f739 fix sh.vim

File Changes

(1 file)

• M runtime/syntax/sh.vim (8)

Patch Links:

• https://github.com/vim/vim/pull/18331.patch
• https://github.com/vim/vim/pull/18331.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18331@github.com>

[h_east]

h-east left a comment (vim/vim#18331)

@dlejay
Your PR will not be merged until you apologize for your dishonesty to me, state that you respect the community's opinion, and actually make improvements.
The above statement has been approved by @chrisbra.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18331/c3306813934@github.com>

[h_east]

Closed #18331.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18331/issue_event/19772184174@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#18331)

Let’s all take a moment to pause. I know there’s been some friction, and I’d like to help mediate.
We welcome contributions that clearly improve Vim, and we can focus on those fixes without revisiting past disagreements.
I also like to assume good intentions and avoid assuming bad faith from anyone here.
I hope this helps to avoid any frictison so we can move forward together and keep on improving Vim.

Thanks.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18331/c3306944184@github.com>

[Maxim Kim]

Thx Christian,

Being a maintainer is hard, however without a context such closure of PRs doesn't looks healthy.

[Shane-XB-Qian]

Shane-XB-Qian left a comment (vim/vim#18331)

> Your PR will not be merged until you apologize for your dishonesty to me, state that you respect the community's opinion, and actually make improvements.

:shrug: if you were interested, telling you a secret:
i and @chrisbra was arguing about 'vim did not like java' :smile: many years ago.

--
shane.xb.qian

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18331/c3311879400@github.com>

[Nick Jensen]

nickspoons left a comment (vim/vim#18331)

This is pretty disturbing behaviour from @h-east, to decide they have been insulted and then close all PRs by @dlejay. This one in particular is totally unrelated to previous discussions.

After reading back through the history, the closest I can see to an insult is when @dlejay said that @h-east should not base their arguments on ChatGPT. Whether or not that had been the case, by that stage @h-east had become more and more aggressive in tone:

Why don't you understand? Think about it a little more deeply.

You're completely possessed by iso646.h. ... You should get an exorcism.

I'm not at all surprised that @dlejay began to feel defensive.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18331/c3316335892@github.com>

[Maxim Kim]

And it is locked again.

I can only agree with @nickspoons that the publicly available evidence doesn't justify closure of all other unrelated PRs.

I would suggest maintainer team to take an action on the situation -- this looks really bad.

Thanks.