Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 5:17:57 AM4/6/22

to vim/vim, Subscribed

On the long run I would like to have my indent, syntax and maybe ftplugin distributed with vim. This is the first step towards this.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/10096

Commit Summary

10250e6 Recognize Kuka Robot Language as filetype krl

File Changes

(2 files)

M runtime/filetype.vim (11)
M src/testdir/test_filetype.vim (1)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 5:39:05 AM4/6/22

to vim/vim, Subscribed

Kuka Robot Language is the programing language of this industrial robots.

Currently I distribute my files here and here.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Apr 6, 2022, 6:01:12 AM4/6/22

to vim/vim, Subscribed

".src" looks like a very generic file extension. It is currently not recognized, but there might be other languages using that extension anyway. Is there something near the start of the file to make sure it is a Kuka Robot Language?

"krl" seems a bit cryptic to me. Have you considered another name? Perhaps "kuka" is easier to recognize. Unless it can be confused with something else.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 6:19:33 AM4/6/22

to vim/vim, Subscribed

KRL is the used abbreviation for Kuka Robot Language. Anyone working with Kuka robots will immediately recognize what that means. If you insist I will change that to kuka anyway.

I will update this pull request with a change for detecting .src files according to the file content.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 6:59:22 AM4/6/22

to vim/vim, Subscribed

Aside from looking at the file content, maybe I should follow the example of *.asa and others and use a g:filetype_src variable as well? Also for *.dat files?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 7:18:11 AM4/6/22

to vim/vim, Push

@KnoP-01 pushed 1 commit.

fa05ea9 Inspect file content and use filetype-overrule

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 7:20:59 AM4/6/22

to vim/vim, Subscribed

This way a user may set the filetype-overrule variable to make new empty *.src and *.dat files be recognized as KRL.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Apr 6, 2022, 8:54:20 AM4/6/22

to vim/vim, Subscribed

> KRL is the used abbreviation for Kuka Robot Language. Anyone working
> with Kuka robots will immediately recognize what that means. If you
> insist I will change that to kuka anyway.

Well, if KRL is a commonly used name it should be OK. Oh, I notice
Wikipedia mentions "The KUKA Robot Language, also known as KRL...".

> I will update this pull request with a change for detecting .src files
> according to the file content.

That will avoid trouble, thanks.

--
Dogs must have a permit signed by the mayor in order to congregate in groups
of three or more on private property.
[real standing law in Oklahoma, United States of America]

/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 8:57:38 AM4/6/22

to vim/vim, Push

@KnoP-01 pushed 1 commit.

c3c09ce Fix test

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 9:28:07 AM4/6/22

to vim/vim, Subscribed

hmm, I don't see what this "freebsd_12 Failing after 20m — Task Summary" has to do with my change.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Apr 6, 2022, 9:50:17 AM4/6/22

to vim/vim, Subscribed

probably flaky. I'll rerun it

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

codecov[bot]

unread,

Apr 6, 2022, 11:56:02 AM4/6/22

to vim/vim, Subscribed

Codecov Report

Merging #10096 (c3c09ce) into master (75a0f3c) will decrease coverage by 79.95%.
The diff coverage is n/a.

@@             Coverage Diff             @@

##           master   #10096       +/-   ##

===========================================

- Coverage   81.96%    2.00%   -79.96%     

===========================================

  Files         167      152       -15     

  Lines      187718   170700    -17018     

  Branches    42338    39498     -2840     

===========================================

- Hits       153857     3430   -150427     

- Misses      21507   166575   +145068     

+ Partials    12354      695    -11659

Flag	Coverage Δ
huge-clang-none	`?`
huge-gcc-none	`?`
huge-gcc-testgui	`?`
huge-gcc-unittests	`2.00% <ø> (ø)`
linux	`2.00% <ø> (-81.96%)`	⬇️
mingw-x64-HUGE	`?`
mingw-x64-HUGE-gui	`?`
windows	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/libvterm/src/rect.h	`0.00% <0.00%> (-96.78%)`	⬇️
src/sha256.c	`0.00% <0.00%> (-96.45%)`	⬇️
src/libvterm/src/parser.c	`0.00% <0.00%> (-95.91%)`	⬇️
src/gui_gtk_f.c	`0.00% <0.00%> (-94.72%)`	⬇️
src/crypt_zip.c	`0.00% <0.00%> (-94.12%)`	⬇️
src/vim9compile.c	`0.00% <0.00%> (-92.42%)`	⬇️
src/debugger.c	`0.00% <0.00%> (-92.23%)`	⬇️
src/eval.c	`0.10% <0.00%> (-92.18%)`	⬇️
src/blob.c	`0.00% <0.00%> (-91.93%)`	⬇️
src/cmdexpand.c	`0.00% <0.00%> (-91.69%)`	⬇️
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a0f3c...c3c09ce. Read the comment docs.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Patrick Meiser-Knosowski

unread,

Apr 6, 2022, 1:56:35 PM4/6/22

to vim/vim, Subscribed

Anything else I should improve/correct?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Apr 6, 2022, 1:58:29 PM4/6/22

to vim/vim, Subscribed

Closed #10096 via 3ad2090.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Apr 6, 2022, 2:17:56 PM4/6/22

to vim/vim, Subscribed

The code to check the file contents is better place in the autoload script. I moved it there.

[vim/vim] Recognize Kuka Robot Language as filetype krl (PR #10096)

Patrick Meiser-Knosowski

You can view, comment on, or merge this pull request online at:

Commit Summary

File Changes

Patch Links:

Patrick Meiser-Knosowski

Bram Moolenaar

Patrick Meiser-Knosowski

Patrick Meiser-Knosowski

Patrick Meiser-Knosowski

Patrick Meiser-Knosowski

Bram Moolenaar

Patrick Meiser-Knosowski

Patrick Meiser-Knosowski

Christian Brabandt

codecov[bot]

Codecov Report

Patrick Meiser-Knosowski

Bram Moolenaar

Bram Moolenaar