[vim/vim] patch 9.2.NNNN: function pointer passed to STRNCMP() instead of a length (PR #20641)

3 views

Skip to first unread message

Shane Harper

unread,

5:24 AM (2 hours ago) 5:24 AM

to vim/vim, Subscribed

Problem:  In the popup 'close' option-value completion check, a function
          pointer (the address of close()) was passed as STRNCMP()'s
          third argument instead of the string length.
Solution: Pass the length (close_len). (Shane Harper)

The user-visible effect was negligible: ":set completepopup=close:o<Tab>"
offered no completions instead of "on" and "off". The fix just corrects
obviously wrong code.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/20641

Commit Summary

6f919cf patch 9.2.NNNN: function pointer passed to STRNCMP() instead of a length

File Changes

(2 files)

M src/optionstr.c (2)
M src/testdir/test_options.vim (3)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward

0 new messages