Commit: patch 9.1.1579: Coverity complains about unchecked return value

2 views
Skip to first unread message

Christian Brabandt

unread,
Jul 22, 2025, 12:15:14 PM7/22/25
to vim...@googlegroups.com
patch 9.1.1579: Coverity complains about unchecked return value

Commit: https://github.com/vim/vim/commit/7cf31ce9c434757301e910244e57aaf4f229e4f9
Author: Yegappan Lakshmanan <yega...@yahoo.com>
Date: Tue Jul 22 18:04:15 2025 +0200

patch 9.1.1579: Coverity complains about unchecked return value

Problem: Coverity complains about unchecked return value in
common_function() (after v9.1.1577)
Solution: Check the return value of skip_generic_func_type_args()
and return in case of an error (Yegappan Lakshmanan)

closes: #17818

Signed-off-by: Yegappan Lakshmanan <yega...@yahoo.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/evalfunc.c b/src/evalfunc.c
index 825df5fbf..c7936238e 100644
--- a/src/evalfunc.c
+++ b/src/evalfunc.c
@@ -5219,7 +5219,8 @@ common_function(typval_T *argvars, typval_T *rettv, int is_funcref)
{
// generic function
start_bracket = name;
- skip_generic_func_type_args(&name);
+ if (skip_generic_func_type_args(&name) == FAIL)
+ goto theend;
}
if (*name != NUL)
s = NULL;
diff --git a/src/version.c b/src/version.c
index c016cf4ff..b5e0da2a2 100644
--- a/src/version.c
+++ b/src/version.c
@@ -719,6 +719,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1579,
/**/
1578,
/**/
Reply all
Reply to author
Forward
0 new messages