[vim/vim] Transparent background of :terminal with 'termguicolors' (#9002)
Milly
Fixed the background of :terminal to be transparent when termguicolors is set.
This PR fixes #2361
hi Terminalandwincolorwill be applied immediately whentgc.
(Whennotgc, it is from before.)- Removed the cache of terminal colors. It is unnecessary.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/9002
Commit Summary
- Respect transparent colors in termguicolors
- Refactor default cterm color detection
- Remove color cache of "Terminal"
- Fix documents of terminal highlight
File Changes
- M runtime/doc/terminal.txt (3)
- M src/highlight.c (12)
- M src/proto/terminal.pro (1)
- M src/terminal.c (126)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
codecov[bot]
Codecov Report
Merging #9002 (71343e1) into master (eaa006d) will decrease coverage by
87.60%.
The diff coverage is0.00%.
@@ Coverage Diff @@ ## master #9002 +/- ## =========================================== - Coverage 90.06% 2.45% -87.61% =========================================== Files 151 149 -2 Lines 168350 165948 -2402 =========================================== - Hits 151627 4077 -147550 - Misses 16723 161871 +145148
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | ? |
|
| huge-gcc-none | ? |
|
| huge-gcc-testgui | ? |
|
| huge-gcc-unittests | 2.45% <0.00%> (+<0.01%) |
⬆️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/highlight.c | 8.04% <ø> (-82.27%) |
⬇️ |
| src/terminal.c | 0.00% <0.00%> (-91.23%) |
⬇️ |
| src/float.c | 0.00% <0.00%> (-99.22%) |
⬇️ |
| src/gui_gtk_f.c | 0.00% <0.00%> (-97.43%) |
⬇️ |
| src/crypt_zip.c | 0.00% <0.00%> (-97.06%) |
⬇️ |
| src/cmdhist.c | 0.00% <0.00%> (-97.00%) |
⬇️ |
| src/sha256.c | 0.00% <0.00%> (-96.94%) |
⬇️ |
| src/evalbuffer.c | 0.00% <0.00%> (-96.88%) |
⬇️ |
| src/textprop.c | 0.00% <0.00%> (-96.84%) |
⬇️ |
| src/match.c | 0.00% <0.00%> (-96.76%) |
⬇️ |
| ... and 139 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update eaa006d...71343e1. Read the comment docs.
Bram Moolenaar
It's hard to see whether this has any undesired side effect. At least it doesn't break any tests.
I wonder if it would be possible to add a regression test for this change?
Anyway, let me include it and await any problem reports.