[vim/vim] fix(completion): avoid break defaul compleition mode (PR #15010)
glepnir
currently we fuzzy search item in match array. so if array is empty we should still find from list. avoid broken default completion behavior.
it's part of #14976, seems like #14976 need some dicussions so split it to a single pr
Fix #15009
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/15010
Commit Summary
- cb90651 fix(completion): avoid break defaul compleition mode
File Changes
(2 files)
- M src/insexpand.c (8)
- M src/testdir/test_ins_complete.vim (6)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
glepnir
@glepnir pushed 1 commit.
- 15e990e fix(completion): avoid break defaul compleition mode
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq commented on this pull request.
In src/testdir/test_ins_complete.vim:
> @@ -2573,6 +2573,15 @@ func Test_complete_fuzzy_match()
call feedkeys("S\<C-x>\<C-o>fb\<C-n>", 'tx')
call assert_equal('fooBaz', g:word)
+ " avoid break default completion behavior
+ set completeopt=fuzzy,menu
+ call setline(1, ['hello help hero h'])
+ exe "normal A\<C-N>"
Will using \<C-X>\<C-N> here be better?
In src/testdir/test_ins_complete.vim:
> @@ -2573,6 +2573,15 @@ func Test_complete_fuzzy_match()
call feedkeys("S\<C-x>\<C-o>fb\<C-n>", 'tx')
call assert_equal('fooBaz', g:word)
+ " avoid break default completion behavior
+ set completeopt=fuzzy,menu
+ call setline(1, ['hello help hero h'])
+ exe "normal A\<C-N>"
+ call assert_equal('hello help hero hello', getline('.'))
+ set completeopt+=noinsert
+ exe "normal Shello help hero h\<C-N>"
ditto
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.