Test failures on amd64

[Elimar Riesebieter]

Hi,

building v8.2.0460 gives the following test failures an amd64:

Failures:
From test_excmd.vim:
Found errors in Test_confirm_cmd_cancel():
Run 1:
function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>16 line 1: Expected 'finished' but got 'running'
Run 2:
function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>20 line 1: Expected 'finished' but got 'running'
Run 3:
function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>24 line 1: Expected 'finished' but got 'running'
Run 4:
function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>28 line 1: Expected 'finished' but got 'running'
Run 5:
function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>32 line 1: Expected 'finished' but got 'running'
Flaky test failed too often, giving up
From test_alot.vim:
Found errors in Test_compiler():
function RunTheTest[40]..Test_compiler line 23: command did not fail: clist
function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does not match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symbol "$foo" requires explicit package name (did you forget to declare "my $foo"?)'


Thanks
--
Elimar

[Dominique Pellé]

I see the same failure in Test_confirm_cmd_cancel()
on one of my 2 machines. The attached patch fixes
it for me. Can you also check?

All other test pass for me. I don't see the failure
in Test_compiler(). What does "/usr/bin/perl --version"
say on your machine? Mine says:

$ /usr/bin/perl --version

This is perl 5, version 26, subversion 1 (v5.26.1) built for
x86_64-linux-gnu-thread-multi
(with 67 registered patches, see perl -V for more detail)
...snip...

Regards
Dominique

[Elimar Riesebieter]

* Dominique Pellé <dominiq...@gmail.com> [2020-03-27 14:07 +0100]:

> Elimar Riesebieter wrote:
>
> > Hi,
> >
> > building v8.2.0460 gives the following test failures an amd64:
> >
> > Failures:
> > From test_excmd.vim:
> > Found errors in Test_confirm_cmd_cancel():
> > Run 1:
> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>16 line 1: Expected 'finished' but got 'running'
> > Run 2:
> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>20 line 1: Expected 'finished' but got 'running'
> > Run 3:
> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>24 line 1: Expected 'finished' but got 'running'
> > Run 4:
> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>28 line 1: Expected 'finished' but got 'running'
> > Run 5:
> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>32 line 1: Expected 'finished' but got 'running'
> > Flaky test failed too often, giving up
> > From test_alot.vim:
> > Found errors in Test_compiler():
> > function RunTheTest[40]..Test_compiler line 23: command did not fail: clist
> > function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does not match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symbol "$foo" requires explicit package name (did you forget to declare "my $foo"?)'
>
> I see the same failure in Test_confirm_cmd_cancel()
> on one of my 2 machines. The attached patch fixes
> it for me. Can you also check?

Appying your patch mede the built successful :-)

>
> All other test pass for me. I don't see the failure
> in Test_compiler(). What does "/usr/bin/perl --version"
> say on your machine? Mine says:

Mine says:

This is perl 5, version 30, subversion 0 (v5.30.0) built for x86_64-linux-gnu-thread-multi
(with 46 registered patches, see perl -V for more detail)

Thanks for cooperation
Elimar
--
Alles, was viel bedacht wird, wird bedenklich!;-)
Friedrich Nietzsche

[Bram Moolenaar]

Dominique wrote:

> Elimar Riesebieter wrote:
>
> > Hi,
> >
> > building v8.2.0460 gives the following test failures an amd64:
> >
> > Failures:
> > From test_excmd.vim:
> > Found errors in Test_confirm_cmd_cancel():
> > Run 1:

> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>16 line 1=

> : Expected 'finished' but got 'running'
> > Run 2:

> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>20 line 1=

> : Expected 'finished' but got 'running'
> > Run 3:

> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>24 line 1=

> : Expected 'finished' but got 'running'
> > Run 4:

> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>28 line 1=

> : Expected 'finished' but got 'running'
> > Run 5:

> > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..<SNR>7_WaitForCommon[11]..<lambda>32 line 1=

> : Expected 'finished' but got 'running'
> > Flaky test failed too often, giving up
> > From test_alot.vim:
> > Found errors in Test_compiler():

> > function RunTheTest[40]..Test_compiler line 23: command did not=
> fail: clist
> > function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\=
> d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does n=
> ot match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symb=
> ol "$foo" requires explicit package name (did you forget to declare "my $fo=

> o"?)'
>
> I see the same failure in Test_confirm_cmd_cancel()
> on one of my 2 machines. The attached patch fixes
> it for me. Can you also check?

Thanks! Such a WaitFor is nicer than a simple delay. But it's hard to
do without being able to reproduce.

> All other test pass for me. I don't see the failure
> in Test_compiler(). What does "/usr/bin/perl --version"
> say on your machine? Mine says:
>
> $ /usr/bin/perl --version
>
> This is perl 5, version 26, subversion 1 (v5.26.1) built for
> x86_64-linux-gnu-thread-multi
> (with 67 registered patches, see perl -V for more detail)
> ...snip...

Strangely, the "does not match" text seems to have part of the error
repeated. Would work to add a ".*" around "explicit", but that would be
weird.

--
No letters of the alphabet were harmed in the creation of this message.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///