[vim/vim] test: Missing change in test code of patch 9.2.0857 (PR #20850)

2 views
Skip to first unread message

mityu

unread,
Jul 26, 2026, 11:09:07 AM (yesterday) Jul 26
to vim/vim, Subscribed

#20848 fixed the problem that closed popup window may remain on window, and introduced a new test suites to check opaque popup windows over terminal windows are properly closed:

  • Test_popup_opacity_global_terminal_close_no_leftover: Check for popup windows that are shown in every tabpages.
  • Test_popup_opacity_tablocal_terminal_close_no_leftover: Check for popup windows that are only visible in current tabpage.

And these two test suites are driven by a new test helper function called s:do_test_popup_opacity_terminal_close_no_leftover().
However, due to wrong implementation of the test helper function, the new two test suites actually tests exactly the same thing. This patch fixes this.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20850

Commit Summary

  • 1ff8261 test: Missing change in test code of patch 9.2.0857

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20850@github.com>

Christian Brabandt

unread,
3:26 PM (6 hours ago) 3:26 PM
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#20850)

thanks


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20850/c5095800111@github.com>

Reply all
Reply to author
Forward
0 new messages