[vim/vim] runtime(vim9): remove extra escaping in Open (PR #19996)
Keith Smiley
Before 71fd19d this function went
through a :! command on all platforms, so it needed special escaping for # and
others. After that commit it doesn't go through that path on unix
platforms. Then with 48581f2 this
escaping was re-added on unix and it's needs since it goes through
sh -c, but it should not have the extra escaping specific to :!.
Specifically my original broken command is:
PATH=/usr/bin:/bin VIMRUNTIME=~/dev/vim/runtime ./src/vim -u NONE -c 'call dist#vim9#Open("https://github.com/keith/dotfiles/blob/7bce9f5c697df6a549cf97bf5606d8b639e5bf5a/vimrc#L19")'
Where the #L19 ends up being opened as %5C#L19. But I verified this
case still works as well:
PATH=/usr/bin:/bin VIMRUNTIME=~/dev/vim/runtime ./src/vim -u NONE -c 'call dist#vim9#Open("foo bar.txt")'
Which is what would otherwise break if we weren't doing any shell
escaping on unix.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19996
Commit Summary
- 2a2a2d8 runtime(vim9): remove extra escaping in Open
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Keith Smiley
keith left a comment (vim/vim#19996)cc @chrisbra and @sahinf since this is related to your recent commits, and I'm hoping I didn't miss another case here
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.