Commit: patch 9.1.0135: Insufficient testing for 'delcombine'

8 views
Skip to first unread message

Christian Brabandt

unread,
Feb 24, 2024, 11:00:08 AM2/24/24
to vim...@googlegroups.com
patch 9.1.0135: Insufficient testing for 'delcombine'

Commit: https://github.com/vim/vim/commit/cd3a13e774823c44cf2e1e483d9e5b6df2cbcf50
Author: zeertzjq <zeer...@outlook.com>
Date: Sat Feb 24 16:51:32 2024 +0100

patch 9.1.0135: Insufficient testing for 'delcombine'

Problem: Insufficient testing for 'delcombine'.
Solution: Add test for both Normal and Insert modes without Arabic.
(zeertzjq)

closes: #14086

Signed-off-by: zeertzjq <zeer...@outlook.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_options.vim b/src/testdir/test_options.vim
index 37dc20187..908f0da12 100644
--- a/src/testdir/test_options.vim
+++ b/src/testdir/test_options.vim
@@ -2234,4 +2234,34 @@ func Test_set_wrap()
set wrap& smoothscroll& scrolloff&
endfunc

+func Test_delcombine()
+ new
+ set backspace=indent,eol,start
+
+ set delcombine
+ call setline(1, 'β̳̈:β̳̈')
+ normal! 0x
+ call assert_equal('β̈:β̳̈', getline(1))
+ exe "normal! A\<BS>"
+ call assert_equal('β̈:β̈', getline(1))
+ normal! 0x
+ call assert_equal('β:β̈', getline(1))
+ exe "normal! A\<BS>"
+ call assert_equal('β:β', getline(1))
+ normal! 0x
+ call assert_equal(':β', getline(1))
+ exe "normal! A\<BS>"
+ call assert_equal(':', getline(1))
+
+ set nodelcombine
+ call setline(1, 'β̳̈:β̳̈')
+ normal! 0x
+ call assert_equal(':β̳̈', getline(1))
+ exe "normal! A\<BS>"
+ call assert_equal(':', getline(1))
+
+ set backspace& delcombine&
+ bwipe!
+endfunc
+
" vim: shiftwidth=2 sts=2 expandtab
diff --git a/src/version.c b/src/version.c
index 9ad2015c5..7ecfc9444 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 135,
/**/
134,
/**/
Reply all
Reply to author
Forward
0 new messages