[vim/vim] Switch Hindu-Arabic to Arabic numerals (PR #13430)
avidseeker
Current standard Arabic keyboards and layout no longer use Hindu-Arabic numerals (٠ ١ ٢ ٣ ٤ ٥ ٦ ٧ ٨ ٩) and use the ordinary Arabic numerals (9 8 7 6 5 4 3 2 1 0).
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/13430
Commit Summary
- 800acb9 Switch Hindu-Arabic to Arabic numerals
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Tony Mechelynck
Is this universal ? I mean, do all countries using an Arabic or Arabic-derived script, no matter the language, use so-called Arabic (Latin) digits (U+0030–U+0039) and none of them either Western Arabic-Indic (U+0660–U+0669) or Eastern Arabic-Indic (U+06F0–U+06F9) ? For example, IIRC I've seen Moroccan (or maybe Algerian?) cars with (Western, I suppose) Arabic-Indic digits on their license plates.
Best regards,
Tony.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Tony Mechelynck
P.S. I also own a Qur'an where all verses are numbered by means of (Eastern) Arabic-Indic digits.
Best regards,
Tony.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
avidseeker
Of course Hindu-Arabic numerals are still widely used in many Arab countries. But as the keymap is specified in the file description:
This is for a standard Microsoft Arabic keyboard layout.
and current keyboard layouts on Windows and also some of Android keyboards use Arabic numerals.
The use case for ( ٥ ٦ ٧ ٨ ٩) is stylistic more than semantic (Compare to usage of Roman numerals in English). For example, Microsoft Word has an option to convert all Hindu-Arabic to Arabic numerals before exporting or printing. That's why books and printed paper may differ from computer text.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
are you intending to work more on that? Or do you think this is ready to include? Then please switch the PR from draft mode into Ready for Review
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Merged #13430 into master.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Clason
missing test update:
Found errors in Test_arabic_toggle_keymap():
command line..script /Users/clason/build/neovim_fork/test/old/testdir/runtest.vim[539]..function RunTheTest[55]..Test_arabic_toggle_keymap line 4: Pattern '^ *٢�١�21٢�١�$' does not match '\[ occurs 74 times]212121'
command line..script /Users/clason/build/neovim_fork/test/old/testdir/runtest.vim[539]..function RunTheTest[55]..Test_arabic_toggle_keymap line 5: Expected '١�٢�12١�٢�' but got '121212'
make[1]: *** [test_arabic] Error 1
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
oh great, I wasn't aware that this keymap is part of a test...
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.