[vim/vim] runtime(erlang): Improve application resource file detection (PR #18842)

5 views
Skip to first unread message

dkearns

unread,
Nov 30, 2025, 10:57:25 PM (2 days ago) Nov 30
to vim/vim, Subscribed

Add content-based filetype detection for application resource files matching extension *.app or *.app.src.

Related: #18835

@jparise @hcs42, does this make sense? Those extensions are generic and the content appears easy to match.

I don't know a lick of Erlang so I may be missing something...or everything.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18842

Commit Summary

  • 1b76e3a runtime(erlang): Improve application resource file detection

File Changes

(4 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18842@github.com>

dkearns

unread,
Nov 30, 2025, 11:05:47 PM (2 days ago) Nov 30
to vim/vim, Push

@dkearns pushed 1 commit.

  • 9bcacd0 runtime(erlang): Improve application resource file detection


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18842/before/1b76e3a938211d7d7f0330c5500834818bbc5fed/after/9bcacd0397b65b5a906572321b06a2157e60017b@github.com>

dkearns

unread,
Dec 1, 2025, 2:46:10 AM (2 days ago) Dec 1
to vim/vim, Push

@dkearns pushed 1 commit.

  • e53baab runtime(erlang): Improve application resource file detection

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18842/before/9bcacd0397b65b5a906572321b06a2157e60017b/after/e53baab0ead3edeb036f09aebe200ac5003c75c6@github.com>

Jon Parise

unread,
Dec 1, 2025, 8:05:33 AM (2 days ago) Dec 1
to vim/vim, Subscribed
jparise left a comment (vim/vim#18842)

@jparise @hcs42, does this make sense? Those extensions are generic and the content appears easy to match.

Yes, this makes sense to me. Like I noted in #18835 (comment), we could also consider constraining these file patterns to their conventional directories, too:

In a development environment, it is acceptable that the .app file for the release resides in the ebin directory, but it is recommended that it is an artifact of the build step. By convention a .app.src located in the src directory is used. This file is nearly identical to the .app file, but certain fields, such as the application version, are replaced during the build step.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18842/c3596451916@github.com>

Csaba Hoch

unread,
4:17 AM (2 hours ago) 4:17 AM
to vim/vim, Subscribed
hcs42 left a comment (vim/vim#18842)

Thanks! It looks good to me too.

Maybe a comment above the function would be nice to make it obvious that this is for Erlang application files.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18842/c3605838824@github.com>

Reply all
Reply to author
Forward
0 new messages