[vim/vim] popup: border is not shown when the popup does not fit (PR #21145)

4 views

Skip to first unread message

h_east

unread,

Aug 24, 2026, 11:46:46 PM (17 hours ago) Aug 24

to vim/vim, Subscribed

Problem:  A popup with a border loses part of the border when it does
          not fit on the screen: the right border is missing when a
          scrollbar is added, and the left border is missing when "pos"
          is right aligned and "fixed" is set.
Solution: Reserve a column for a scrollbar that is added after the width
          and the position were computed.  For a right aligned popup
          with "fixed", scroll the text instead of moving the border off
          the screen.

fixes: #21128

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/21145

Commit Summary

1c3d077 popup: border is not shown when the popup does not fit

File Changes

(6 files)

M src/popupwin.c (18)
A src/testdir/dumps/Test_popupwin_border_edge_1.dump (16)
A src/testdir/dumps/Test_popupwin_border_edge_2.dump (16)
M src/testdir/dumps/Test_popupwin_mask_4.dump (16)
M src/testdir/dumps/Test_popupwin_mask_5.dump (6)
M src/testdir/test_popupwin.vim (30)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

3:25 PM (1 hour ago) 3:25 PM

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#21145)

thanks

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward

0 new messages