[vim/vim] Avoid using C++ keyword `new` as function parameter name (PR #19558)

Wei Tang

unread,

Mar 2, 2026, 10:13:36 PM (21 hours ago) Mar 2

to vim/vim, Subscribed

Problem:
A recent commit introduced a new function named update_highlight_overrides() in highlight.pro and highlight.c, one of the parameter names conflicts with the C++ keyword new. This causes compilation issues on Windows when VIM is compiled with OLE enabled, as "if_ole.cpp" cannot compile due to the conflict (after v9.2.0093).

Solution:
Rename the parameter name of update_highlight_overrides() from new to hl_new.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/19558

Commit Summary

4edba57 Avoid using C++ keyword `new` as function parameter name

File Changes

(2 files)

M src/highlight.c (6)
M src/proto/highlight.pro (2)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Foxe Chen

unread,

6:13 AM (13 hours ago) 6:13 AM

to vim/vim, Subscribed

@64-bitman approved this pull request.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

2:54 PM (5 hours ago) 2:54 PM

to vim/vim, Subscribed

Closed #19558 via 238a846.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

2:54 PM (5 hours ago) 2:54 PM

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#19558)