[vim/vim] feat; add 'termsync' setting (PR #19541)
Foxe Chen
Same as Neovim's termsync option. Surprised this wasn't already added, consdering how simple it was to implement and it reduces flickering greatly for me on my machine.
Here's a before and after comparsion:
https://github.com/user-attachments/assets/fb45ab56-b3a8-491b-b589-3c818fa6cd25
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19541
Commit Summary
- dcdfd82 add 'termsync' setting
File Changes
(10 files)
- M runtime/doc/options.txt (9)
- M runtime/doc/tags (2)
- M src/drawscreen.c (4)
- M src/main.c (3)
- M src/option.c (8)
- M src/option.h (1)
- M src/optiondefs.h (3)
- M src/proto/option.pro (1)
- M src/proto/term.pro (2)
- M src/term.c (70)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 18e4c8e add 'termsync' setting
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 0e364c7 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- befd2f0 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 1401cf2 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 00a08c7 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 4525f76 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 3a012f8 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- ec005a0 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- f2b8654 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 56aa075 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 798f03b add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- af717ea add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 417d677 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19541)I found #11718 which this PR is related to, seems like bram did not get the point of something like this. However it has noticeably reduces flickering for me, so I guess there is a point.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- ed46538 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- d589505 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- af7f30f add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19541)out_str((char_u *)"\033[?2026$p");
Hm, we typically have those as t_<letter> options. Don't we need this here as well instead of hard coding this?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Javier Jaramago Fernández
JavierJF left a comment (vim/vim#19541)This PR fixes the popup flickering, but does it as a side effect of the feature, also since it only does it for terminal that supports this feature, I think that having correctness back for popups without transparencies is important. So opaque popups don't require terminals with this feature to avoid rendering issues, while popups with transparencies will require it for avoiding flickering.
Due to this, I think that even with this PR, the with changes from #19534 are still required. Said this, I think it's a great feature to have 👍 .
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19541)out_str((char_u *)"\033[?2026$p");
Hm, we typically have those as
t_<letter>options. Don't we need this here as well instead of hard coding this?
Well it looks to me that all terminals that support synchronized output use this same escape sequence. However I think it is a good idea to add a t_ option for consistency
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 46281ba add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 41d6c3c add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- a089f84 add 'termsync' setting
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19541)Okay I have made it so the escape codes to begin and end synchronized output are configurable by the user. I left the \033[?2026$p escape code hardcoded, because all terminals that support synchronized output use this, and it makes things simpler (esp. when detecting the response).
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.