[vim/vim] sh.vim: support complex shebang lines (#7411)

13 views
Skip to first unread message

Aaron Griffin

unread,
Dec 2, 2020, 12:16:26 PM12/2/20
to vim/vim, Subscribed

It's common/popular to include flags on shell shebang lines, meaning
this syntax detection will not pick up /bin/bash -e or similar.

Adjust the regexes for these cases


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/7411

Commit Summary

  • sh.vim: support complex shebang lines

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Moshe Avni

unread,
Dec 3, 2020, 5:09:55 AM12/3/20
to vim/vim, Subscribed

@Moshem123 approved this pull request.

cecamp

unread,
Dec 3, 2020, 11:11:51 AM12/3/20
to vim/vim, Subscribed

Closed #7411.

cecamp

unread,
Dec 3, 2020, 11:11:51 AM12/3/20
to vim/vim, Subscribed

Please try out syntax/sh.vim on my website, v197.

Aaron Griffin

unread,
Jul 16, 2021, 11:42:48 AM7/16/21
to vim/vim, Subscribed

Please try out syntax/sh.vim on my website, v197.

@cecamp Sorry, I didn't bother following up on this until now. I'm curious as to the reason for closing this.

This is a file shipped with vim proper, not an external file. While I fully understand a more featureful sh.vim file exists, I can't understand that being a reason to not improve the one shipped with vim.

Gary Johnson

unread,
Jul 16, 2021, 11:54:33 AM7/16/21
to reply+ACY5DGG5AHB2XYYR6J...@reply.github.com, vim...@googlegroups.com
On 2021-07-16, Aaron Griffin wrote:
> Please try out syntax/sh.vim on my website, v197.
>
> @cecamp Sorry, I didn't bother following up on this until now. I'm curious as
> to the reason for closing this.
>
> This is a file shipped with vim proper, not an external file. While I fully
> understand a more featureful sh.vim file exists, I can't understand that being
> a reason to not improve the one shipped with vim.

The one currently shipped with Vim is v198.

Regards,
Gary

vim-dev ML

unread,
Jul 16, 2021, 11:54:48 AM7/16/21
to vim/vim, vim-dev ML, Your activity

cecamp

unread,
Jul 16, 2021, 3:43:36 PM7/16/21
to vim/vim, vim-dev ML, Comment

And v198 (syntax/sh.vim) includes your (Aaron Griffin) patch. Seemed like a good reason to close to me!


You are receiving this because you commented.

Reply all
Reply to author
Forward
0 new messages