[vim/vim] Extend items() to support a blob (PR #18080)

Yegappan Lakshmanan

unread,

Aug 21, 2025, 10:27:15 PMAug 21

to vim/vim, Subscribed

The items() function currently supports a List, Tuple, Dict or a String. Extend it to also support a Blob.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/18080

Commit Summary

789d085 Extend items() to support blob

File Changes

(11 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Aug 21, 2025, 10:31:24 PMAug 21

to vim/vim, Push

@yegappan pushed 1 commit.

96c2996 Update test

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christ van Willegen

unread,

Aug 21, 2025, 10:42:17 PMAug 21

to vim...@googlegroups.com, nor...@github.com

+/*

+ * "items(blob)" function

+ * Converts a Blob into a List of [index, byte] pairs.

+ * Caller must have already checked that argvars[0] is a Blob.

+ * A null blob behaves like an empty blob.

+ */

+ void

+blob2items(typval_T *argvars, typval_T *rettv)

+{

+ blob_T *blob = argvars[0].vval.v_blob;

+

+ if (rettv_list_alloc(rettv) == FAIL)

+ return;

+

+ for (int i = 0; i < blob_len(blob); i++)

+ {

+ list_T *l2 = list_alloc();

+ if (l2 == NULL)

+ return;

Memory leak rettv?

+

+ if (list_append_list(rettv->vval.v_list, l2) == FAIL)

+ {

+ vim_free(l2);

+ return;

+ }

+

+ if (list_append_number(l2, i) == FAIL

+ || list_append_number(l2, blob_get(blob, i)) == FAIL)

+ return;

Memory leak l2?

+ }

+}

Christ van Willegen

Yegappan Lakshmanan

unread,

Aug 21, 2025, 10:48:09 PMAug 21

to vim...@googlegroups.com, nor...@github.com

On Thu, Aug 21, 2025 at 7:42 PM Christ van Willegen <cvwil...@gmail.com> wrote:

+/*
+ * "items(blob)" function
+ * Converts a Blob into a List of [index, byte] pairs.
+ * Caller must have already checked that argvars[0] is a Blob.
+ * A null blob behaves like an empty blob.
+ */
+ void
+blob2items(typval_T *argvars, typval_T *rettv)
+{
+ blob_T *blob = argvars[0].vval.v_blob;
+
+ if (rettv_list_alloc(rettv) == FAIL)
+ return;
+
+ for (int i = 0; i < blob_len(blob); i++)
+ {
+ list_T *l2 = list_alloc();
+ if (l2 == NULL)
+ return;

Memory leak rettv?

No. This function is expected to set rettv to a List. In case of failure, this will return an empty List.

This is the same as how other types (List, Dict, Tuple, String) are handled. The returned List

will be freed later.

+
+ if (list_append_list(rettv->vval.v_list, l2) == FAIL)
+ {
+ vim_free(l2);
+ return;
+ }
+
+ if (list_append_number(l2, i) == FAIL
+ || list_append_number(l2, blob_get(blob, i)) == FAIL)
+ return;

Memory leak l2?

No. The list l2 is already added to rettv.

Regards,

Yegappan

+ }
+}

Yegappan Lakshmanan

unread,

Aug 22, 2025, 9:38:12 PMAug 22

to vim/vim, Push

@yegappan pushed 1 commit.

c646405 Extend items() to support blob

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 23, 2025, 7:18:05 AMAug 23

to vim/vim, Subscribed

Closed #18080 via da34f84.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 23, 2025, 7:18:05 AMAug 23

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#18080)