[vim/vim] solve VMS build issues (PR #20131)
Zoltan Arpadffy
OpenVMS version needs to build on VAX, ALPHA, IA64 and X86_64 architectures, some of them strictly C89 compliant without many new C features and includes capabilities.
This pull request is an attempt to solve all the VMS related build issues on all platforms for the recent Vim version 9.2
Please review
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20131
Commit Summary
- 934ddf8 solve VMS build issues
File Changes
(10 files)
- M src/Make_vms.mms (48)
- M src/clipboard.c (2)
- M src/fuzzy.c (2)
- M src/memline.c (18)
- M src/os_unix.c (4)
- M src/os_vms.c (7)
- M src/os_vms_conf.h (13)
- M src/structs.h (6)
- M src/textprop.c (41)
- M src/xdiff/xprepare.c (12)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
@arpadffy pushed 1 commit.
- e3bad10 correct the #ifdef HAVE_STDINT_H
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christ van Willegen
Zoltan Arpadffy
@arpadffy pushed 1 commit.
- 0c3e98a fix tailing spaces
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
> @@ -58,7 +58,9 @@ // Define to `int' if <sys/types.h> doesn't define. // #undef uid_t -// Define to `unsigned int' or other type that is 32 bit. +// Define some types from stdint - older VMS do not have stdint.h +#define UINT8_T unsigned char +#define UINT16_T unsigned short
Instead of defining those, would the following make more sense?
#ifndef HAVE_STDINT_H typedef unsigned char uint8_t; typedef unsigned short uint16_t; typedef unsigned int uint32_t; #endif
Then we can get rid of the conditionals in all the other C files.
In src/os_unix.c:
> pid = fork(); +# endif
This looks suspicious. Doesn't this break this function for Vim on VMS? Is this actually working for you? echo system(['ls'])?
Perhaps we need this:
#ifndef VMS pid = fork(); #else pid = -1; #endif if (pid == -1) { UNBLOCK_SIGNALS(&curset); close(fd_out[0]); close(fd_out[1]); emsg(_("\nCannot fork\n")); return NULL; }
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
arpadffy left a comment (vim/vim#20131)Let me try on all architectures... and I'll get back to you.
Thanks,
Z
On Mon, 4 May 2026 at 21:50, Christian Brabandt ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In src/os_vms_conf.h
> <https://github.com/vim/vim/pull/20131#discussion_r3184013602>:
> > @@ -58,7 +58,9 @@
> // Define to `int' if <sys/types.h> doesn't define.
> // #undef uid_t
>
> -// Define to `unsigned int' or other type that is 32 bit.
> +// Define some types from stdint - older VMS do not have stdint.h
> +#define UINT8_T unsigned char
> +#define UINT16_T unsigned short
>
> Instead of defining those, would the following make more sense?
>
> #ifndef HAVE_STDINT_H
> typedef unsigned char uint8_t;
> typedef unsigned short uint16_t;
> typedef unsigned int uint32_t;
> #endif
>
> Then we can get rid of the conditionals in all the other C files.
>
> In src/os_unix.c
> <https://github.com/vim/vim/pull/20131#discussion_r3184053073>:
> > pid = fork();
> +# endif
>
> This looks suspicious. Doesn't this break this function for Vim on VMS? Is
> this actually working for you? echo system(['ls'])?
>
> Perhaps we need this:
>
> UNBLOCK_SIGNALS(&curset);
> close(fd_out[0]);
> close(fd_out[1]);
> emsg(_("\nCannot fork\n"));
> return NULL;
> }
>
> —
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AG7S6QBTPH3C74SNILTVQCL4ZDYCHAVCNFSM6AAAAACYPXOGI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DEMRSHEYTKOBVGE>
> .
> or Android
> <https://play.google.com/store/apps/details
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
@arpadffy pushed 1 commit.
- 93b424d Merge branch 'vim:master' into master
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
@arpadffy pushed 4 commits.
- d1588ff Revert "fix tailing spaces"
- bb36908 Revert "correct the #ifdef HAVE_STDINT_H"
- f3cec9d Revert "solve VMS build issues"
- 326205b Define needed types when stdint.h is missing
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
@arpadffy commented on this pull request.
In src/os_unix.c:
> pid = fork(); +# endif
VMS use system, it does not have fork()... and the shell output works as expected
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
Okay, if you say it works for you then I guess this is fine
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
@arpadffy pushed 1 commit.
- 4da5b04 Merge branch 'vim:master' into master
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
@arpadffy pushed 1 commit.
- 3bac3cb Merge branch 'vim:master' into master
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
@arpadffy pushed 1 commit.
- 7fd85ce Merge branch 'vim:master' into master
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Zoltan Arpadffy
arpadffy left a comment (vim/vim#20131)@chrisbra thank you for the suggestion. it works well on VMS side on all architectures.
However, the test fail on not related issues.
What shall we do?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20131)thanks, let me re-trigger CI, I think those were just flaky tests that failed
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.