[patch][win32] Support also intl.dll (gettext)

105 views
Skip to first unread message

Ken Takata

unread,
Oct 6, 2018, 7:30:38 AM10/6/18
to vim_dev
Hi Bram,

Quoting from https://www.vim.org/download.php#pc

> newer intl library libintl
> The included libintl.dll does not support encoding conversion. If you
> have installed the iconv library, as mentioned above, you can install a
> gettext library that uses it. Get "intl.dll" from the bin directory in
> the gettext-win32 archive and store it as "libintl.dll" in the same
> directory as gvim.exe, overwriting the file that may already be there.

Currently we support libintl.dll and libintl-8.dll, but I think it's also
better to support intl.dll.
With this patch, users don't need to rename intl.dll to libintl.dll anymore.
(We already do a similar thing for iconv.dll.)

(We can get much newer versions of libintl and libiconv at
https://github.com/mlocati/gettext-iconv-windows, and already included in
gvim81.exe, though.)

Regards,
Ken Takata

support-alt-gettext-dll.patch

Bram Moolenaar

unread,
Oct 6, 2018, 9:03:39 AM10/6/18
to vim...@googlegroups.com, Ken Takata
Thanks. I'll also add a note in the help file.

I assume for the installer we'll use both iconv.dll and libintl.dll with
conversion support. Please update the build instructions if that
changed.

--
hundred-and-one symptoms of being an internet addict:
160. You get in the elevator and double-click the button for the floor
you want.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Ken Takata

unread,
Oct 6, 2018, 9:28:14 AM10/6/18
to vim_dev
Hi Bram,

2018/10/6 Sat 22:03:39 UTC+9 Bram Moolenaar wrote:
> Ken Takata wrote:
>
> > Quoting from https://www.vim.org/download.php#pc
> >
> > > newer intl library libintl
> > > The included libintl.dll does not support encoding conversion. If you
> > > have installed the iconv library, as mentioned above, you can install a
> > > gettext library that uses it. Get "intl.dll" from the bin directory in
> > > the gettext-win32 archive and store it as "libintl.dll" in the same
> > > directory as gvim.exe, overwriting the file that may already be there.
> >
> > Currently we support libintl.dll and libintl-8.dll, but I think it's also
> > better to support intl.dll.
> > With this patch, users don't need to rename intl.dll to libintl.dll anymore.
> > (We already do a similar thing for iconv.dll.)
> >
> > (We can get much newer versions of libintl and libiconv at
> > https://github.com/mlocati/gettext-iconv-windows, and already included in
> > gvim81.exe, though.)
>
> Thanks. I'll also add a note in the help file.
>
> I assume for the installer we'll use both iconv.dll and libintl.dll with
> conversion support. Please update the build instructions if that
> changed.

Thank you for merging the patch.
I don't think we need to update the build instructions.


BTW, I found a similar item in the todo.txt:

> - Load intl.dll too, not only libintl.dll. (Mike Williams, 2006 May 9, docs
> patch May 10)

I think we can remove it now.
(I couldn't find the Mike's patch, though.)

Regards,
Ken Takata

Bram Moolenaar

unread,
Oct 6, 2018, 10:30:43 AM10/6/18
to vim...@googlegroups.com, Ken Takata
It was a message directly to me.

Looks like I'm only 12 years behind including patches :-).

--
hundred-and-one symptoms of being an internet addict:
163. You go outside for the fresh air (at -30 degrees) but open the
window first to hear new mail arrive.
Reply all
Reply to author
Forward
0 new messages