[vim/vim] check length of line (PR #18953)

1 view
Skip to first unread message

sxt1001

unread,
9:59 AM (5 hours ago) 9:59 AM
to vim/vim, Subscribed

Add a check for the length of the line, it should be a number not less than 0.

Fixes:#17935


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18953

Commit Summary

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18953@github.com>

sxt1001

unread,
10:15 AM (5 hours ago) 10:15 AM
to vim/vim, Push

@xiaoge1001 pushed 1 commit.


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18953/before/6dd1fe9d57f5e1dc43b4d6309e342da2de89a5fc/after/97259a11fddba17d3b4910e0091a52a926ff7f3b@github.com>

Christian Brabandt

unread,
3:04 PM (8 minutes ago) 3:04 PM
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#18953)

Hm, that indicates an overflow. Looking at your reproduction:

dd if=/dev/zero bs=1M count=10240 | tr '\0' 'A' > bigline.txt

that indicates 1 single line of 1,048,576 bytes * 10,240 = 10,737,418,240 bytes (without newlines).

colnr_T is int. So are you using 32bit arch? Don't you see an error message for such a long error with your patch?

I guess it makes sense. @zeertzjq what do you think?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18953/c3666956029@github.com>

Reply all
Reply to author
Forward
0 new messages