[vim/vim] Memory leak with :breakadd expr (PR #18844)

zeertzjq

unread,

Dec 1, 2025, 1:57:52 AM (2 days ago) Dec 1

to vim/vim, Subscribed

Problem: Memory leak with :breakadd expr.
Solution: Free debug_oldval and debug_newval before assigning to them.

It seems that :breakadd expr doesn't work as documented at all. This PR
only fixes the memory leak. The tests are for the existing behavior.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/18844

Commit Summary

8473a9c Memory leak with :breakadd expr

File Changes

(2 files)

M src/debugger.c (6)
M src/testdir/test_debugger.vim (51)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Dec 1, 2025, 2:13:53 AM (2 days ago) Dec 1

to vim/vim, Push

@zeertzjq pushed 1 commit.

93449e4 Memory leak with :breakadd expr

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Dec 1, 2025, 2:29:49 PM (2 days ago) Dec 1

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#18844)

Thanks, the memory leak is my fault I guess. I remember some wonky behavior when implementing the expr part of it. Seems like it is not much used really.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Dec 1, 2025, 2:50:35 PM (2 days ago) Dec 1

to vim/vim, Subscribed

Closed #18844 via a474de6.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward