[vim/vim] Add additional dnsmasq keywords to Vim runtime (PR #20616)
Pooyan Khanjankhani
Some keywords such as help, test, connmark, and version have no effect on the configuration, but they are still accepted as valid options by dnsmasq --test -C dnsmasq.conf. For completeness, I have added them to the Vim runtime syntax definition as well.
For additional validation, you can refer to the test suite here
Sorting the keyword list was not necessary, but it made it easier to spot duplicates and inconsistencies. It appears the ordering had drifted over time, so I also normalized the ordering as part of this change.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20616
Commit Summary
File Changes
(1 file)
- M runtime/syntax/dnsmasq.vim (88)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20616)Thanks, did you try to reach the maintainer?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Pooyan Khanjankhani
TheKhanj left a comment (vim/vim#20616)If you mean the maintainer of the dnsmasq project, not really. I just looked through their code and sent a couple of patches for some minor issues I found, but I haven't talked to them about the Vim integration. 🙄
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#20616)No the maintainer of the syntax file, listed in the "Maintainer:" field at the top. Sorry, I assumed you were the maintainer.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Pooyan Khanjankhani
TheKhanj left a comment (vim/vim#20616)Ah, I hadn't even read the header to know there was a maintainer listed 😂. I'm not sure what the process is, should I reach out to them, or can you handle it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20616)Yeah, please try to reach out (make sure you apply the :s suggestion to his contact mail:
In any case, I haven't heard from Thilo in a while, so it might be possible he is no longer active. So, if you don't hear back within the next week or so, we can merge it here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Pooyan Khanjankhani
TheKhanj left a comment (vim/vim#20616)Aw, that :s trick was cute. I decoded it using sed and tried to send them an email, but it seems the address is dead. Gmail bounced it:
Address not found
Your message wasn't delivered to <email> because the address couldn't be found, or is unable to receive mail.
The response from the remote server was:
550 Unroutable address
Whois on the domain:
Domain: <domain>
Nserver: ns1.your-server.de
Nserver: ns3.second-ns.de
Nserver: ns.second-ns.com
Status: connect
Changed: 2015-09-02T11:06:16+02:00
The domain looks like it's been abandoned since 2015, site is just an "under construction" page. Couldn't find them anywhere else either. 🙄
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20616)okay, then let me merge it. But thanks for trying.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.