[vim/vim] git regression: keywordprg is not set to git show anymore (Issue #9845)

30 views
Skip to first unread message

Jiri Slaby

unread,
Feb 25, 2022, 4:04:37 AM2/25/22
to vim/vim, Subscribed

Steps to reproduce

  1. Open vim in a git directory
  2. Paste a SHA (or use git rebase -i @^^)
  3. Press shift-k.

Expected behaviour

git show is run with the above SHA. But man is run instead. This is apparently a result of 2f0936c#diff-e92ab7d5e3bfe3e88cfb645f5ce7d4e05cc4f6495d72e8458e97f95c229fdb7e

Why was the file removed?

Version of Vim

8.2.4375

Environment

  • openSUSE Tumbleweed
  • xterm
  • xterm-256color
  • bash

Logs and stack traces

No response


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9845@github.com>

Jiri Slaby

unread,
Feb 25, 2022, 4:10:23 AM2/25/22
to vim/vim, Subscribed

This is coming from tpope/vim-git@6ee5e1f . @tpope, why do you think there is no good idea there? Is there any replacement now?


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9845/1050669972@github.com>

Christian Brabandt

unread,
Feb 25, 2022, 5:18:04 AM2/25/22
to vim/vim, Subscribed

this comes from #9477 I'd suggest to discuss this with @tpope at his upstream repo: https://github.com/tpope/vim-git


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9845/1050721733@github.com>

Tim Pope

unread,
Feb 25, 2022, 3:29:03 PM2/25/22
to vim/vim, Subscribed

This was never an officially documented feature, just an ill-conceived idea that leaked out of ftplugin/git.vim. If you want to bring it back, you can add it yourself in after/ftplugin/gitrebase.vim:

setlocal keywordprg=git\ show


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9845/1051232851@github.com>

David Disseldorp

unread,
Feb 25, 2022, 3:53:15 PM2/25/22
to vim/vim, Subscribed

This was never an officially documented feature, just an ill-conceived idea that leaked out of ftplugin/git.vim. If you want to bring it back, you can add it yourself in after/ftplugin/gitrebase.vim:

setlocal keywordprg=git\ show

Thanks for the workaround. I'm also a heavy user of this functionality (it makes git rebase -i really nice) so had hoped to see the regression fixed, but I guess I'll have to live with the local modification.


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9845/1051257748@github.com>

Christian Brabandt

unread,
Feb 28, 2022, 3:29:52 PM2/28/22
to vim/vim, Subscribed

closing then.


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9845/1054635378@github.com>

Christian Brabandt

unread,
Feb 28, 2022, 3:29:54 PM2/28/22
to vim/vim, Subscribed

Closed #9845.


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issue/9845/issue_event/6157341837@github.com>

Jiri Slaby

unread,
Mar 10, 2022, 2:13:46 AM3/10/22
to vim/vim, Subscribed

@ddiss: https://build.opensuse.org/request/show/960651


Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/9845/1063734784@github.com>

Reply all
Reply to author
Forward
0 new messages