[vim/vim] ftplugin/spec.vim: Revert change dropping <SID> from SpecChangelog (PR #9032)

22 views
Skip to first unread message

Brian C. Lane

unread,
Oct 21, 2021, 1:24:45 PM10/21/21
to vim/vim, Subscribed

Without this it will return an error when creating a new changelog
entry:
"Unknown function: SpecChangelog"


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/9032

Commit Summary

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

K.Takata

unread,
Oct 21, 2021, 10:31:15 PM10/21/21
to vim/vim, Subscribed

Have you tried contacting the maintainer?

Bram Moolenaar

unread,
Oct 23, 2021, 4:06:16 PM10/23/21
to vim/vim, Subscribed

Jakub Jelen

unread,
Nov 8, 2021, 4:58:55 AM11/8/21
to vim/vim, Subscribed

Verified that this solves my issue that I had last couple of weeks.

codecov[bot]

unread,
Nov 16, 2021, 11:58:38 AM11/16/21
to vim/vim, Subscribed

Codecov Report

Merging #9032 (a403350) into master (94e7d34) will decrease coverage by 87.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@

##           master    #9032       +/-   ##

===========================================

- Coverage   90.09%    2.45%   -87.64%     

===========================================

  Files         151      149        -2     

  Lines      169614   166117     -3497     

===========================================

- Hits       152807     4085   -148722     

- Misses      16807   162032   +145225     
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests 2.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/float.c 0.00% <0.00%> (-99.22%) ⬇️
src/gui_gtk_f.c 0.00% <0.00%> (-97.43%) ⬇️
src/crypt_zip.c 0.00% <0.00%> (-97.06%) ⬇️
src/sound.c 0.00% <0.00%> (-97.03%) ⬇️
src/cmdhist.c 0.00% <0.00%> (-97.00%) ⬇️
src/sha256.c 0.00% <0.00%> (-96.94%) ⬇️
src/evalbuffer.c 0.00% <0.00%> (-96.92%) ⬇️
src/textprop.c 0.00% <0.00%> (-96.84%) ⬇️
src/match.c 0.00% <0.00%> (-96.76%) ⬇️
src/libvterm/src/rect.h 0.00% <0.00%> (-96.56%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e7d34...a403350. Read the comment docs.

zdohnal

unread,
May 17, 2022, 2:57:34 AM5/17/22
to vim/vim, Subscribed

This PR is partially fixed in Vim project - it is only missing a downstream patch from Fedora
vim-7.4-releasestring-1318991.patch.txt

I've sent the fix to @ignatenkobrain via email as well.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9032/c1128486196@github.com>

Christian Brabandt

unread,
Aug 20, 2023, 3:27:56 PM8/20/23
to vim/vim, Subscribed

Merged #9032 into master.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9032/issue_event/10138810579@github.com>

Reply all
Reply to author
Forward
0 new messages