Renaming str2blob() and blob2str() to strs2blob() and blob2strs()

13 views
Skip to first unread message

Yegappan Lakshmanan

unread,
Jan 18, 2025, 12:16:44 PM1/18/25
to vim_dev
Hi all,

In the PR (https://github.com/vim/vim/pull/16459) to add the support for passing
a List of strings to the str2blob() function, zeertzjq gave the following comment:

Since a list of strings are now used, should these functions be now renamed to blob2strs() and strs2blob() instead?


I don't have a preference either way.  Any preferences/suggestions?


Thanks,

Yegappan


Christian Brabandt

unread,
Jan 18, 2025, 12:22:20 PM1/18/25
to vim...@googlegroups.com
If we really want to rename it, shouldn't it be blob2list()/list2blob()
but that already exists.

I think it is fine to keep the str suffix/prefix, strs doesn't really
seem to be used anyhow, so it's not really clear what it stands for and
looks a bit unusual/wrong

Thanks,
Christian
--
Too cool to calypso,
Too tough to tango,
Too weird to watusi
-- The Only Ones
Reply all
Reply to author
Forward
0 new messages