[vim/vim] popup menu shadow is not cleared when the menu shrinks (PR #20750)

3 views

Skip to first unread message

h_east

unread,

8:01 AM (7 hours ago) 8:01 AM

to vim/vim, Subscribed

Problem:  Popup menu shadow is not cleared when the menu shrinks, leaving a
          stale shadow cell on the empty (~) lines above the menu.
Solution: Exclude the two shadow corner cells that are never drawn from the
          popup menu area, so the background is redrawn and clears the cell.

fixes: #20740

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/20750

Commit Summary

6b9dfdc popup menu shadow is not cleared when the menu shrinks

File Changes

(4 files)

M src/popupmenu.c (21)
A src/testdir/dumps/Test_wildmenu_pum_shadow_1.dump (12)
A src/testdir/dumps/Test_wildmenu_pum_shadow_2.dump (12)
M src/testdir/test_cmdline.vim (38)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

h_east

unread,

8:24 AM (7 hours ago) 8:24 AM

to vim/vim, Subscribed

h-east left a comment (vim/vim#20750)

I found a similar bug in Insert mode (the area is not redrawn correctly when the PUM + shadow shrinks), so I am currently looking into it separately.